From: David Miller <davem@davemloft.net>
To: claudiu.manoil@freescale.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH net-next 4/4] gianfar: Add paged allocation and Rx S/G
Date: Fri, 10 Jul 2015 18:26:50 -0700 (PDT) [thread overview]
Message-ID: <20150710.182650.555632423222261831.davem@davemloft.net> (raw)
In-Reply-To: <1436459084-14103-5-git-send-email-claudiu.manoil@freescale.com>
From: Claudiu Manoil <claudiu.manoil@freescale.com>
Date: Thu, 9 Jul 2015 19:24:44 +0300
> @@ -2839,6 +2815,94 @@ static irqreturn_t gfar_transmit(int irq, void *grp_id)
> return IRQ_HANDLED;
> }
>
> +static bool gfar_add_rx_frag(struct gfar_rx_buff *rxb, unsigned int lstatus,
> + struct sk_buff *skb, bool first)
> +{
You really are again playing Russian Roulette with the type of
'lstatus' here. Use 'u32' consistently.
> +static struct sk_buff *gfar_get_next_rxbuff(struct gfar_priv_rx_q *rx_queue,
> + unsigned long lstatus,
> + struct sk_buff *skb)
Likewise.
prev parent reply other threads:[~2015-07-11 6:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 16:24 [PATCH net-next 0/4] gianfar: Add Rx S/G Claudiu Manoil
2015-07-09 16:24 ` [PATCH net-next 1/4] gianfar: Bundle Rx allocation, cleanup Claudiu Manoil
2015-07-09 16:24 ` [PATCH net-next 2/4] gianfar: Fix and cleanup rxbd status handling Claudiu Manoil
2015-07-11 1:25 ` David Miller
2015-07-13 7:43 ` Manoil Claudiu
2015-07-09 16:24 ` [PATCH net-next 3/4] gianfar: Use ndev, more Rx path cleanup Claudiu Manoil
2015-07-09 16:24 ` [PATCH net-next 4/4] gianfar: Add paged allocation and Rx S/G Claudiu Manoil
2015-07-11 1:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150710.182650.555632423222261831.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=claudiu.manoil@freescale.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).