From: Thomas Graf <tgraf@suug.ch>
To: Julian Anastasov <ja@ssi.bg>
Cc: roopa@cumulusnetworks.com, rshearma@brocade.com,
ebiederm@xmission.com, hannes@stressinduktion.org,
pshelar@nicira.com, jesse@nicira.com, davem@davemloft.net,
daniel@iogearbox.net, tom@herbertland.com, edumazet@google.com,
jiri@resnulli.us, marcelo.leitner@gmail.com,
stephen@networkplumber.org, jpettit@nicira.com, kaber@trash.net,
netdev@vger.kernel.org, dev@openvswitch.org
Subject: Re: [RFC net-next 11/22] dst: Metadata destinations
Date: Fri, 10 Jul 2015 21:19:50 +0200 [thread overview]
Message-ID: <20150710191950.GA15042@pox.localdomain> (raw)
In-Reply-To: <alpine.LFD.2.11.1507102139530.1754@ja.home.ssi.bg>
On 07/10/15 at 09:57pm, Julian Anastasov wrote:
>
> Hello,
>
> On Fri, 10 Jul 2015, Thomas Graf wrote:
>
> > --- a/net/ipv4/route.c
> > +++ b/net/ipv4/route.c
> > @@ -1691,6 +1691,8 @@ static int ip_route_input_slow(struct sk_buff *skb, __be32 daddr, __be32 saddr,
> > by fib_lookup.
> > */
> >
> > + skb_dst_drop(skb);
> > +
>
> This is not very safe. There are places that
> call ip_route_input() for temporary lookups and they
> do not set NULL. For example, icmp_route_lookup(),
> may be there are other such places...
Wow. What a tremendous hack ;-) It saves and restores the original
dst ref to avoid the leaked reference.
> OTOH, ip_options_rcv_srr() looks correct to use
> skb_dst_set(skb, NULL), may be such call should be
> added if it is missing...
Agreed. This seems to be the right fix. I'll apply to this
icmp_route_lookup() as well.
Thanks!
next prev parent reply other threads:[~2015-07-10 19:19 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 14:19 [RFC net-next 00/22] Lightweight & flow based tunneling Thomas Graf
2015-07-10 14:19 ` [RFC net-next 01/22] rtnetlink: introduce new RTA_ENCAP_TYPE and RTA_ENCAP attributes Thomas Graf
2015-07-10 14:19 ` [RFC net-next 02/22] lwtunnel: infrastructure for handling light weight tunnels like mpls Thomas Graf
2015-07-10 14:19 ` [RFC net-next 03/22] ipv4: support for fib route lwtunnel encap attributes Thomas Graf
2015-07-10 15:36 ` Eric Dumazet
[not found] ` <1436542616.24939.52.camel-XN9IlZ5yJG9HTL0Zs8A6p/gx64E7kk8eUsxypvmhUTTZJqsBc5GL+g@public.gmane.org>
2015-07-10 16:54 ` Thomas Graf
[not found] ` <20150710165436.GC11654-4EA/1caXOu0mYvmMESoHnA@public.gmane.org>
2015-07-10 16:56 ` roopa
2015-07-10 14:19 ` [RFC net-next 04/22] ipv6: " Thomas Graf
2015-07-10 14:19 ` [RFC net-next 05/22] lwtunnel: support dst output redirect function Thomas Graf
2015-07-10 14:19 ` [RFC net-next 07/22] ipv6: rt6_info output redirect to tunnel output Thomas Graf
2015-07-10 14:19 ` [RFC net-next 08/22] mpls: export mpls functions for use by mpls iptunnels Thomas Graf
[not found] ` <cover.1436537414.git.tgraf-G/eBtMaohhA@public.gmane.org>
2015-07-10 14:19 ` [RFC net-next 06/22] ipv4: redirect dst output to lwtunnel output Thomas Graf
2015-07-10 14:19 ` [RFC net-next 09/22] mpls: ip tunnel support Thomas Graf
2015-07-10 14:19 ` [RFC net-next 10/22] ip_tunnel: Make ovs_tunnel_info and ovs_key_ipv4_tunnel generic Thomas Graf
2015-07-10 14:19 ` [RFC net-next 11/22] dst: Metadata destinations Thomas Graf
[not found] ` <1b20319e1ff0f2be28e783b90ac48738d6a8b72b.1436537414.git.tgraf-G/eBtMaohhA@public.gmane.org>
2015-07-10 18:57 ` Julian Anastasov
2015-07-10 19:19 ` Thomas Graf [this message]
2015-07-10 14:19 ` [RFC net-next 12/22] arp: Inherit metadata dst when creating ARP requests Thomas Graf
2015-07-10 18:55 ` Sergei Shtylyov
2015-07-10 14:19 ` [RFC net-next 13/22] vxlan: Flow based tunneling Thomas Graf
2015-07-10 14:19 ` [RFC net-next 14/22] route: Extend flow representation with tunnel key Thomas Graf
2015-07-10 14:19 ` [RFC net-next 15/22] route: Per route IP tunnel metadata via lightweight tunnel Thomas Graf
2015-07-10 14:19 ` [RFC net-next 16/22] fib: Add fib rule match on tunnel id Thomas Graf
2015-07-10 14:19 ` [RFC net-next 17/22] vxlan: Factor out device configuration Thomas Graf
2015-07-10 14:19 ` [RFC net-next 18/22] openvswitch: Make tunnel set action attach a metadata dst Thomas Graf
2015-07-13 22:55 ` Joe Stringer
2015-07-14 9:30 ` Thomas Graf
2015-07-10 14:19 ` [RFC net-next 19/22] openvswitch: Move dev pointer into vport itself Thomas Graf
2015-07-10 14:19 ` [RFC net-next 20/22] openvswitch: Abstract vport name through ovs_vport_name() Thomas Graf
2015-07-10 14:19 ` [RFC net-next 21/22] openvswitch: Use regular VXLAN net_device device Thomas Graf
2015-07-10 14:19 ` [RFC net-next 22/22] openvswitch: Use regular GRE net_device instead of vport Thomas Graf
2015-07-16 8:59 ` Simon Horman
2015-07-16 14:52 ` Thomas Graf
2015-07-16 21:36 ` Pravin Shelar
2015-07-17 10:58 ` Thomas Graf
2015-07-17 17:10 ` Pravin Shelar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150710191950.GA15042@pox.localdomain \
--to=tgraf@suug.ch \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=hannes@stressinduktion.org \
--cc=ja@ssi.bg \
--cc=jesse@nicira.com \
--cc=jiri@resnulli.us \
--cc=jpettit@nicira.com \
--cc=kaber@trash.net \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=roopa@cumulusnetworks.com \
--cc=rshearma@brocade.com \
--cc=stephen@networkplumber.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).