From: David Miller <davem@davemloft.net>
To: fw@strlen.de
Cc: netdev@vger.kernel.org, edumazet@google.com
Subject: Re: [PATCH -next] Revert "ipv4: use skb coalescing in defragmentation"
Date: Sat, 11 Jul 2015 21:17:14 -0700 (PDT) [thread overview]
Message-ID: <20150711.211714.1422141941490741042.davem@davemloft.net> (raw)
In-Reply-To: <1436571456-27905-1-git-send-email-fw@strlen.de>
From: Florian Westphal <fw@strlen.de>
Date: Sat, 11 Jul 2015 01:37:36 +0200
> This reverts commit 3cc4949269e01f39443d0fcfffb5bc6b47878d45.
>
> There is nothing wrong with coalescing during defragmentation, it
> reduces truesize overhead and simplifies things for the receiving
> socket (no fraglist walk needed).
>
> However, it also destroys geometry of the original fragments.
> While that doesn't cause any breakage (we make sure to not exceed largest
> original size) ip_do_fragment contains a 'fastpath' that takes advantage
> of a present frag list and results in fragments that (in most cases)
> match what was received.
>
> In case its needed the coalescing could be done later, when we're sure
> the skb is not forwarded. But discussion during NFWS resulted in
> 'lets just remove this for now'.
>
> Cc: Eric Dumazet <edumazet@google.com>
> Signed-off-by: Florian Westphal <fw@strlen.de>
Applied, thanks for following up on this.
prev parent reply other threads:[~2015-07-12 4:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-10 23:37 [PATCH -next] Revert "ipv4: use skb coalescing in defragmentation" Florian Westphal
2015-07-11 5:01 ` Eric Dumazet
2015-07-12 4:17 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150711.211714.1422141941490741042.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).