netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: socketcan@hartkopp.net
Cc: eric.dumazet@gmail.com, tom@herbertland.com,
	netdev@vger.kernel.org, linux-can@vger.kernel.org,
	sunil.kovvuri@gmail.com, jonathon.reinhart@gmail.com
Subject: Re: Fighting out-of-order reception with RPS?
Date: Sun, 12 Jul 2015 20:22:41 -0700 (PDT)	[thread overview]
Message-ID: <20150712.202241.2051134175805521232.davem@davemloft.net> (raw)
In-Reply-To: <55A2BCD8.4020303@hartkopp.net>

From: Oliver Hartkopp <socketcan@hartkopp.net>
Date: Sun, 12 Jul 2015 21:15:36 +0200

> Just some remarks about CAN and CAN frames as you suggest GRO which is
> completely pointless for CAN.

GRO may be pointless for CAN, but NAPI _definitely_ is useful for every
single network device, period.

So you should do NAPI for reasons outside of packet receive ordering,
and in return you'll have your packet ordering problem solved as well.

I really am stumped as to why you are avoiding NAPI so vehemently.

  reply	other threads:[~2015-07-13  3:22 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-08 17:49 Fighting out-of-order reception with RPS? Oliver Hartkopp
2015-07-08 21:17 ` Tom Herbert
2015-07-09  5:55   ` Oliver Hartkopp
2015-07-10  2:48     ` Tom Herbert
2015-07-10 20:36       ` Oliver Hartkopp
2015-07-11  4:35         ` Eric Dumazet
2015-07-12 19:15           ` Oliver Hartkopp
2015-07-13  3:22             ` David Miller [this message]
2015-07-13  4:57             ` Eric Dumazet
2015-07-14 17:09               ` Oliver Hartkopp
2015-07-14 18:02                 ` Tom Herbert
2015-07-14 19:03                   ` David Miller
2015-07-14 19:05                     ` Oliver Hartkopp
2015-07-13 19:08             ` Tom Herbert
2015-07-09  6:34 ` Holger Schurig
2015-07-09  8:48   ` Oliver Hartkopp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150712.202241.2051134175805521232.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=jonathon.reinhart@gmail.com \
    --cc=linux-can@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=socketcan@hartkopp.net \
    --cc=sunil.kovvuri@gmail.com \
    --cc=tom@herbertland.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).