From: David Miller <davem@davemloft.net>
To: vivien.didelot@savoirfairelinux.com
Cc: netdev@vger.kernel.org, linux@roeck-us.net, andrew@lunn.ch,
linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com
Subject: Re: [PATCH v2] net: dsa: mv88e6xxx: add write access to debugfs regs file
Date: Sun, 12 Jul 2015 20:25:13 -0700 (PDT) [thread overview]
Message-ID: <20150712.202513.301354636371108143.davem@davemloft.net> (raw)
In-Reply-To: <1788707459.58885.1436751570981.JavaMail.zimbra@savoirfairelinux.com>
From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Date: Sun, 12 Jul 2015 21:39:30 -0400 (EDT)
> I hardly see how this debug interface can be made generic to other
> DSA drivers, since the format of hardware tables or some registers
> seem very specific to the switch chip.
You feel this way because you are focusing on register values and not what
those values represent.
Ie. could you export the values in those registers in a generic format
that other devices could convert their register values to as well?
Stop focusing so tightly on the exact thing you've implemented and
consider things on a much higher level.
prev parent reply other threads:[~2015-07-13 3:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 21:13 [PATCH v2] net: dsa: mv88e6xxx: add write access to debugfs regs file Vivien Didelot
2015-07-11 6:01 ` David Miller
2015-07-11 18:36 ` Vivien Didelot
2015-07-12 2:08 ` David Miller
2015-07-13 1:39 ` Vivien Didelot
2015-07-13 3:25 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150712.202513.301354636371108143.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=andrew@lunn.ch \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).