From: David Miller <davem@davemloft.net>
To: anuradhak@cumulusnetworks.com
Cc: sfeldma@gmail.com, netdev@vger.kernel.org,
roopa@cumulusnetworks.com, gospo@cumulusnetworks.com,
wkok@cumulusnetworks.com
Subject: Re: [PATCH net-next v5 1/4] net core: Add protodown support.
Date: Mon, 13 Jul 2015 14:34:32 -0700 (PDT) [thread overview]
Message-ID: <20150713.143432.56479578476726354.davem@davemloft.net> (raw)
In-Reply-To: <1436481330-4599-2-git-send-email-anuradhak@cumulusnetworks.com>
From: anuradhak@cumulusnetworks.com
Date: Thu, 9 Jul 2015 15:35:27 -0700
> +/* proto_flags - port state information can be passed to the switch driver and
> + * used to determine the phys state of the switch port */
> +enum {
> + IF_PROTOF_DOWN = 1<<0 /* set switch port phys state down */
> +};
Realistically, do we really foresee any other proto flags being added in
the future?
Unless there is a strong sense that we will have some, this is
insanely overengineered with all of these bit masking capabilities and
such and nested attributes.
I'd say just do one boolean attribute and that's it.
next prev parent reply other threads:[~2015-07-13 21:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 22:35 [PATCH net-next v5 1/4] net core: Add protodown support anuradhak
2015-07-13 21:34 ` David Miller [this message]
2015-07-14 1:09 ` Anuradha Karuppiah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150713.143432.56479578476726354.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=anuradhak@cumulusnetworks.com \
--cc=gospo@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
--cc=sfeldma@gmail.com \
--cc=wkok@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).