* [PATCH v2] netlink: reset skb->peeked when reuse orphan skb for next broadcast
@ 2015-07-10 12:21 Konstantin Khlebnikov
2015-07-13 8:05 ` Herbert Xu
0 siblings, 1 reply; 2+ messages in thread
From: Konstantin Khlebnikov @ 2015-07-10 12:21 UTC (permalink / raw)
To: netdev, David S. Miller; +Cc: Eric Dumazet, Herbert Xu
This patch clears skb->peeked set by previous recipient of broadcast.
Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Fixes: add05ad4e9f5 ("unix/dgram: peek beyond 0-sized skbs")
---
net/netlink/af_netlink.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 921e0d8dfe3a..f4427f4bf223 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -1967,6 +1967,7 @@ static void do_one_broadcast(struct sock *sk,
* delivered to a previous socket.
*/
skb_orphan(p->skb2);
+ p->skb2->peeked = 0;
}
}
if (p->skb2 == NULL) {
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] netlink: reset skb->peeked when reuse orphan skb for next broadcast
2015-07-10 12:21 [PATCH v2] netlink: reset skb->peeked when reuse orphan skb for next broadcast Konstantin Khlebnikov
@ 2015-07-13 8:05 ` Herbert Xu
0 siblings, 0 replies; 2+ messages in thread
From: Herbert Xu @ 2015-07-13 8:05 UTC (permalink / raw)
To: Konstantin Khlebnikov; +Cc: netdev, David S. Miller, Eric Dumazet
On Fri, Jul 10, 2015 at 03:21:34PM +0300, Konstantin Khlebnikov wrote:
> This patch clears skb->peeked set by previous recipient of broadcast.
>
> Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
> Fixes: add05ad4e9f5 ("unix/dgram: peek beyond 0-sized skbs")
Per my earlier email, this patch is not needed if we fix the root
cause.
Thanks,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-13 8:05 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-10 12:21 [PATCH v2] netlink: reset skb->peeked when reuse orphan skb for next broadcast Konstantin Khlebnikov
2015-07-13 8:05 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).