From: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
To: linux-netdev <netdev@vger.kernel.org>,
Mahesh Bandewar <maheshb@google.com>
Cc: "David S. Miller" <davem@davemloft.net>, Jiri Benc <jbenc@redhat.com>
Subject: [PATCH v3 2/5] ipvlan: plug memory leak in ipvlan_link_delete
Date: Tue, 14 Jul 2015 16:35:51 +0300 [thread overview]
Message-ID: <20150714133551.22448.48397.stgit@buzz> (raw)
In-Reply-To: <20150714132941.22448.42175.stgit@buzz>
Add missing kfree_rcu(addr, rcu);
Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
---
drivers/net/ipvlan/ipvlan_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
index 048ecf0c76fb..7d81e37c3f76 100644
--- a/drivers/net/ipvlan/ipvlan_main.c
+++ b/drivers/net/ipvlan/ipvlan_main.c
@@ -507,6 +507,7 @@ static void ipvlan_link_delete(struct net_device *dev, struct list_head *head)
list_for_each_entry_safe(addr, next, &ipvlan->addrs, anode) {
ipvlan_ht_addr_del(addr, !dev->dismantle);
list_del(&addr->anode);
+ kfree_rcu(addr, rcu);
}
list_del_rcu(&ipvlan->pnode);
next prev parent reply other threads:[~2015-07-14 13:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 13:35 [PATCH v3 0/5] ipvlan: cleanups and fixes Konstantin Khlebnikov
2015-07-14 13:35 ` [PATCH v3 1/5] ipvlan: remove counters of ipv4 and ipv6 addresses Konstantin Khlebnikov
2015-07-14 13:35 ` Konstantin Khlebnikov [this message]
2015-07-14 13:35 ` [PATCH v3 3/5] ipvlan: unhash addresses without synchronize_rcu Konstantin Khlebnikov
2015-07-14 13:35 ` [PATCH v3 4/5] ipvlan: use rcu_deference_bh() in ipvlan_queue_xmit() Konstantin Khlebnikov
2015-07-14 13:35 ` [PATCH v3 5/5] ipvlan: ignore addresses from ipv6 autoconfiguration Konstantin Khlebnikov
2015-07-16 4:33 ` [PATCH v3 0/5] ipvlan: cleanups and fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150714133551.22448.48397.stgit@buzz \
--to=khlebnikov@yandex-team.ru \
--cc=davem@davemloft.net \
--cc=jbenc@redhat.com \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).