From: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
To: linux-netdev <netdev@vger.kernel.org>,
Mahesh Bandewar <maheshb@google.com>
Cc: "David S. Miller" <davem@davemloft.net>, Jiri Benc <jbenc@redhat.com>
Subject: [PATCH v3 5/5] ipvlan: ignore addresses from ipv6 autoconfiguration
Date: Tue, 14 Jul 2015 16:35:55 +0300 [thread overview]
Message-ID: <20150714133555.22448.82099.stgit@buzz> (raw)
In-Reply-To: <20150714132941.22448.42175.stgit@buzz>
Inet6addr notifier is atomic and runs in bh context without RTNL when
ipv6 receives router advertisement packet and performs autoconfiguration.
Proper fix still in discussion. Let's at least plug the bug.
v1: http://lkml.kernel.org/r/20150514135618.14062.1969.stgit@buzz
v2: http://lkml.kernel.org/r/20150703125840.24121.91556.stgit@buzz
Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
---
drivers/net/ipvlan/ipvlan_main.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ipvlan/ipvlan_main.c b/drivers/net/ipvlan/ipvlan_main.c
index e995bc501ee6..20b58bdecf75 100644
--- a/drivers/net/ipvlan/ipvlan_main.c
+++ b/drivers/net/ipvlan/ipvlan_main.c
@@ -655,6 +655,10 @@ static int ipvlan_addr6_event(struct notifier_block *unused,
struct net_device *dev = (struct net_device *)if6->idev->dev;
struct ipvl_dev *ipvlan = netdev_priv(dev);
+ /* FIXME IPv6 autoconf calls us from bh without RTNL */
+ if (in_softirq())
+ return NOTIFY_DONE;
+
if (!netif_is_ipvlan(dev))
return NOTIFY_DONE;
next prev parent reply other threads:[~2015-07-14 13:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 13:35 [PATCH v3 0/5] ipvlan: cleanups and fixes Konstantin Khlebnikov
2015-07-14 13:35 ` [PATCH v3 1/5] ipvlan: remove counters of ipv4 and ipv6 addresses Konstantin Khlebnikov
2015-07-14 13:35 ` [PATCH v3 2/5] ipvlan: plug memory leak in ipvlan_link_delete Konstantin Khlebnikov
2015-07-14 13:35 ` [PATCH v3 3/5] ipvlan: unhash addresses without synchronize_rcu Konstantin Khlebnikov
2015-07-14 13:35 ` [PATCH v3 4/5] ipvlan: use rcu_deference_bh() in ipvlan_queue_xmit() Konstantin Khlebnikov
2015-07-14 13:35 ` Konstantin Khlebnikov [this message]
2015-07-16 4:33 ` [PATCH v3 0/5] ipvlan: cleanups and fixes David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150714133555.22448.82099.stgit@buzz \
--to=khlebnikov@yandex-team.ru \
--cc=davem@davemloft.net \
--cc=jbenc@redhat.com \
--cc=maheshb@google.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox