* [PATCH] pkt_sched: sch_qfq: remove unused member of struct qfq_sched
@ 2015-07-13 22:12 Andrea Parri
2015-07-16 0:21 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Andrea Parri @ 2015-07-13 22:12 UTC (permalink / raw)
To: Jamal Hadi Salim, David S. Miller
Cc: Paolo Valente, netdev, linux-kernel, Andrea Parri
The member (u32) "num_active_agg" of struct qfq_sched has been unused
since its introduction in 462dbc9101acd38e92eda93c0726857517a24bbd
"pkt_sched: QFQ Plus: fair-queueing service at DRR cost" and (AFAICT)
there is no active plan to use it; this removes the member.
Signed-off-by: Andrea Parri <parri.andrea@gmail.com>
Acked-by: Paolo Valente <paolo.valente@unimore.it>
---
net/sched/sch_qfq.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/net/sched/sch_qfq.c b/net/sched/sch_qfq.c
index b8d73bc..ffaeea6 100644
--- a/net/sched/sch_qfq.c
+++ b/net/sched/sch_qfq.c
@@ -186,7 +186,6 @@ struct qfq_sched {
u64 oldV, V; /* Precise virtual times. */
struct qfq_aggregate *in_serv_agg; /* Aggregate being served. */
- u32 num_active_agg; /* Num. of active aggregates */
u32 wsum; /* weight sum */
u32 iwsum; /* inverse weight sum */
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] pkt_sched: sch_qfq: remove unused member of struct qfq_sched
2015-07-13 22:12 [PATCH] pkt_sched: sch_qfq: remove unused member of struct qfq_sched Andrea Parri
@ 2015-07-16 0:21 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-07-16 0:21 UTC (permalink / raw)
To: parri.andrea; +Cc: jhs, paolo.valente, netdev, linux-kernel
From: Andrea Parri <parri.andrea@gmail.com>
Date: Tue, 14 Jul 2015 00:12:05 +0200
> The member (u32) "num_active_agg" of struct qfq_sched has been unused
> since its introduction in 462dbc9101acd38e92eda93c0726857517a24bbd
> "pkt_sched: QFQ Plus: fair-queueing service at DRR cost" and (AFAICT)
> there is no active plan to use it; this removes the member.
>
> Signed-off-by: Andrea Parri <parri.andrea@gmail.com>
> Acked-by: Paolo Valente <paolo.valente@unimore.it>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-16 0:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-13 22:12 [PATCH] pkt_sched: sch_qfq: remove unused member of struct qfq_sched Andrea Parri
2015-07-16 0:21 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).