From: David Miller <davem@davemloft.net>
To: eric.dumazet@gmail.com
Cc: netdev@vger.kernel.org, yoshfuji@linux-ipv6.org
Subject: Re: [PATCH net] ipv6: lock socket in ip6_datagram_connect()
Date: Wed, 15 Jul 2015 17:26:12 -0700 (PDT) [thread overview]
Message-ID: <20150715.172612.2146759620527413231.davem@davemloft.net> (raw)
In-Reply-To: <1436854222.1374.4.camel@edumazet-glaptop2.roam.corp.google.com>
From: Eric Dumazet <eric.dumazet@gmail.com>
Date: Tue, 14 Jul 2015 08:10:22 +0200
> From: Eric Dumazet <edumazet@google.com>
>
> ip6_datagram_connect() is doing a lot of socket changes without
> socket being locked.
>
> This looks wrong, at least for udp_lib_rehash() which could corrupt
> lists because of concurrent udp_sk(sk)->udp_portaddr_hash accesses.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
Applied and queued up for -stable, thanks.
prev parent reply other threads:[~2015-07-16 0:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 6:10 [PATCH net] ipv6: lock socket in ip6_datagram_connect() Eric Dumazet
2015-07-14 7:56 ` Herbert Xu
2015-07-16 0:26 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150715.172612.2146759620527413231.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).