netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Graf <tgraf@suug.ch>
To: Meelis Roos <mroos@linux.ee>
Cc: sparclinux@vger.kernel.org,
	Linux Kernel list <linux-kernel@vger.kernel.org>,
	netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
	Herbert Xu <herbert@gondor.apana.org.au>,
	Daniel Borkmann <daniel@iogearbox.net>,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: 4.1 regression in resizable hashtable tests
Date: Fri, 17 Jul 2015 10:04:56 +0200	[thread overview]
Message-ID: <20150717080456.GA13814@pox.localdomain> (raw)
In-Reply-To: <alpine.LRH.2.11.1507022208200.28236@math.ut.ee>

On 07/02/15 at 10:09pm, Meelis Roos wrote:
> [   33.425061] Running rhashtable test nelem=8, max_size=65536, shrinking=0
> [   33.425154] Test 00:
> [   33.534470]   Adding 50000 keys
> [   34.743553] Info: encountered resize
> [   34.743698] Info: encountered resize
> [   34.743838] Info: encountered resize
> [   34.744057] Info: encountered resize
> [   34.744430] Info: encountered resize
> [   34.745139] Info: encountered resize
> [   34.746441] Info: encountered resize
> [   34.749055] Info: encountered resize
> [   34.754469] Info: encountered resize
> [   34.764836] Info: encountered resize
> [   34.785696] Info: encountered resize
> [   34.827448] Info: encountered resize
> [   34.896936]   Traversal complete: counted=49993, nelems=50000, entries=50000, table-jumps=12
> [   34.897056] Test failed: Total count mismatch ^^^

I do see count mismatches as well due to the design of the walker
which restarts and thus sees certain entries multiple times.

Do you have this commit as well?

Author: Phil Sutter <phil@nwl.cc>
Date:   Mon Jul 6 15:51:20 2015 +0200

    rhashtable: fix for resize events during table walk

  reply	other threads:[~2015-07-17  8:04 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-01 10:21 4.1 regression in resizable hashtable tests Meelis Roos
2015-07-02 12:31 ` Thomas Graf
2015-07-02 19:09   ` Meelis Roos
2015-07-17  8:04     ` Thomas Graf [this message]
2015-07-17 10:26       ` Phil Sutter
2015-07-17 10:29         ` Phil Sutter
2015-07-17 10:31         ` Thomas Graf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150717080456.GA13814@pox.localdomain \
    --to=tgraf@suug.ch \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=geert@linux-m68k.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mroos@linux.ee \
    --cc=netdev@vger.kernel.org \
    --cc=sparclinux@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).