From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Graf Subject: Re: 4.1 regression in resizable hashtable tests Date: Fri, 17 Jul 2015 12:31:07 +0200 Message-ID: <20150717103107.GA18033@pox.localdomain> References: <20150702123130.GA20843@pox.localdomain> <20150717080456.GA13814@pox.localdomain> <20150717102636.GA21732@orbit.nwl.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii To: Meelis Roos , sparclinux@vger.kernel.org, Linux Kernel list , netdev@vger.kernel.org, "David S. Miller" , Herbert Xu , Daniel Borkmann , Geert Uytterhoeven Return-path: Content-Disposition: inline In-Reply-To: <20150717102636.GA21732@orbit.nwl.cc> Sender: sparclinux-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 07/17/15 at 12:26pm, Phil Sutter wrote: > On Fri, Jul 17, 2015 at 10:04:56AM +0200, Thomas Graf wrote: > > On 07/02/15 at 10:09pm, Meelis Roos wrote: > > > [ 33.425061] Running rhashtable test nelem=8, max_size=65536, shrinking=0 > > > [ 33.425154] Test 00: > > > [ 33.534470] Adding 50000 keys > > > [ 34.743553] Info: encountered resize > > > [ 34.743698] Info: encountered resize > > > [ 34.743838] Info: encountered resize > > > [ 34.744057] Info: encountered resize > > > [ 34.744430] Info: encountered resize > > > [ 34.745139] Info: encountered resize > > > [ 34.746441] Info: encountered resize > > > [ 34.749055] Info: encountered resize > > > [ 34.754469] Info: encountered resize > > > [ 34.764836] Info: encountered resize > > > [ 34.785696] Info: encountered resize > > > [ 34.827448] Info: encountered resize > > > [ 34.896936] Traversal complete: counted=49993, nelems=50000, entries=50000, table-jumps=12 > > > [ 34.897056] Test failed: Total count mismatch ^^^ > > > > I do see count mismatches as well due to the design of the walker > > which restarts and thus sees certain entries multiple times. > > > > Do you have this commit as well? > > > > Author: Phil Sutter > > Date: Mon Jul 6 15:51:20 2015 +0200 > > > > rhashtable: fix for resize events during table walk > > Thomas, this should be resolved already. Meelis replied[1] to my patch, > stating it fixes that problem for him. Though he's still waiting for > your proposed patch to add a schedule() call so the kernel won't > complain on his slow UltraSparc. :) > > Cheers, Phil > > [1]: http://www.spinics.net/lists/netdev/msg335767.html OK, good to know. I've posted the schedule patch today: https://patchwork.ozlabs.org/patch/497035/