* [PATCH net-next]r8169:Disable advertise full duplex on chip id RTL_GIGA_MAC_VER_09. Disable advertise full duplex on chip id RTL_GIGA_MAC_VER_09 wich support random full duplex.(very sad) On branch master Your branch is ahead of 'origin/master' by 18 commits. (use "git push" to publish your local commits)
@ 2015-07-18 10:03 Corcodel Marian
2015-07-19 5:21 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Corcodel Marian @ 2015-07-18 10:03 UTC (permalink / raw)
To: netdev; +Cc: Corcodel Marian, Corcodel Marian
[-- Attachment #1: Type: text/plain, Size: 255 bytes --]
Changes to be committed:
modified: drivers/net/ethernet/realtek/r8169.c
Signed-off-by: Corcodel Marian <asu@192-168-0-3.rdsnet.ro>
---
drivers/net/ethernet/realtek/r8169.c | 19 +++++++++++++++----
1 file changed, 15 insertions(+), 4 deletions(-)
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Committer-Corcodel-Marian-corcodel.marian-gmail.com.patch --]
[-- Type: text/x-patch; name="0001-Committer-Corcodel-Marian-corcodel.marian-gmail.com.patch", Size: 1162 bytes --]
diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
index 714af89..a373679 100644
--- a/drivers/net/ethernet/realtek/r8169.c
+++ b/drivers/net/ethernet/realtek/r8169.c
@@ -1918,12 +1918,23 @@ static int rtl8169_set_speed_xmii(struct net_device *dev,
if (adv & ADVERTISED_10baseT_Half)
auto_nego |= ADVERTISE_10HALF;
- if (adv & ADVERTISED_10baseT_Full)
- auto_nego |= ADVERTISE_10FULL;
+ if (!tp->mac_version == RTL_GIGA_MAC_VER_09) {
+ if (adv & ADVERTISED_10baseT_Full)
+ auto_nego |= ADVERTISE_10FULL;
+ } else {
+ netif_info(tp, link, dev,
+ "PHY does not support 10Mbps full duplex\n");
+ }
if (adv & ADVERTISED_100baseT_Half)
auto_nego |= ADVERTISE_100HALF;
- if (adv & ADVERTISED_100baseT_Full)
- auto_nego |= ADVERTISE_100FULL;
+ if (!tp->mac_version == RTL_GIGA_MAC_VER_09) {
+ if (adv & ADVERTISED_100baseT_Full)
+ auto_nego |= ADVERTISE_100FULL;
+ } else {
+ netif_info(tp, link, dev,
+ "PHY does not support 100Mbps full duplex\n");
+ }
+
auto_nego |= ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next]r8169:Disable advertise full duplex on chip id RTL_GIGA_MAC_VER_09. Disable advertise full duplex on chip id RTL_GIGA_MAC_VER_09 wich support random full duplex.(very sad) On branch master Your branch is ahead of 'origin/master' by 18 commits. (use "git push" to publish your local commits)
2015-07-18 10:03 [PATCH net-next]r8169:Disable advertise full duplex on chip id RTL_GIGA_MAC_VER_09. Disable advertise full duplex on chip id RTL_GIGA_MAC_VER_09 wich support random full duplex.(very sad) On branch master Your branch is ahead of 'origin/master' by 18 commits. (use "git push" to publish your local commits) Corcodel Marian
@ 2015-07-19 5:21 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-07-19 5:21 UTC (permalink / raw)
To: corcodel.marian; +Cc: netdev, asu
This is still ver far from acceptable. You aren't even talking to us when
we ask you questions and ask you to make changes, you just make another
improperly formatted submission of a bad patch all over again.
Your entire description is in your Subject line, and it insufficiently
describes your change.
Frankly, I am very sick and tired of these low quality submissions. I want to
know where these changes are coming from, who they are important to, and most
importantly why it is so difficult for you to submit your changes properly.
Just simply _LOOK_ at postings by other developers who submit changes
that successfully get accepted by us.
_LOOK_ at how their Subject line looks, and mimick what they do _EXACTLY_
_LOOK_ at how their commit messages look, how detailed they are, how
descriptive they are, and how they are formatted and composed, and
mimick _EACTLY_ what they are doing.
This isn't rocket science, if you want us to take your changes seriously
you _MUST_ learn how to conform to our patch submission methods and
expectations.
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-19 5:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-18 10:03 [PATCH net-next]r8169:Disable advertise full duplex on chip id RTL_GIGA_MAC_VER_09. Disable advertise full duplex on chip id RTL_GIGA_MAC_VER_09 wich support random full duplex.(very sad) On branch master Your branch is ahead of 'origin/master' by 18 commits. (use "git push" to publish your local commits) Corcodel Marian
2015-07-19 5:21 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).