From: David Miller <davem@davemloft.net>
To: dvlasenk@redhat.com
Cc: tgraf@suug.ch, tom@herbertland.com, alexander.h.duyck@redhat.com,
kadlec@blackhole.kfki.hu, herbert@gondor.apana.org.au,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] jhash: Deinline jhash and jhash2
Date: Sun, 19 Jul 2015 11:41:22 -0700 (PDT) [thread overview]
Message-ID: <20150719.114122.199681184036898625.davem@davemloft.net> (raw)
In-Reply-To: <1437320160-13290-1-git-send-email-dvlasenk@redhat.com>
From: Denys Vlasenko <dvlasenk@redhat.com>
Date: Sun, 19 Jul 2015 17:36:00 +0200
> This patch deinlines jhash and jhash2.
>
> It also removes rhashtable_jhash2(key, length, seed)
> because it was merely calling jhash2(key, length, seed).
>
> With this .config: http://busybox.net/~vda/kernel_config,
> after deinlining these functions have sizes and callsite counts
> as follows:
>
> jhash: 297 bytes, 111 calls
> jhash2: 205 bytes, 136 calls
>
> Total size decrease is about 33,000 bytes:
>
> text data bss dec hex filename
> 90663567 17221960 36659200 144544727 89d93d7 vmlinux5
> 90630370 17221864 36659200 144511434 89d11ca vmlinux.after
>
> Signed-off-by: Denys Vlasenko <dvlasenk@redhat.com>
No performance metrics at all have been provided, so this should
not be applied.
prev parent reply other threads:[~2015-07-19 18:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-19 15:36 [PATCH v3] jhash: Deinline jhash and jhash2 Denys Vlasenko
2015-07-19 18:41 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150719.114122.199681184036898625.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@redhat.com \
--cc=dvlasenk@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=kadlec@blackhole.kfki.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).