From: David Miller <davem@davemloft.net>
To: herbert@gondor.apana.org.au
Cc: linux@stwm.de, netdev@vger.kernel.org, tom@herbertland.com,
eric.dumazet@gmail.com
Subject: Re: Revert "sit: Add gro callbacks to sit_offload"
Date: Mon, 20 Jul 2015 16:53:29 -0700 (PDT) [thread overview]
Message-ID: <20150720.165329.259656303413900871.davem@davemloft.net> (raw)
In-Reply-To: <20150720095538.GA13740@gondor.apana.org.au>
From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Mon, 20 Jul 2015 17:55:38 +0800
> This patch reverts 19424e052fb44da2f00d1a868cbb51f3e9f4bbb5 ("sit:
> Add gro callbacks to sit_offload") because it generates packets
> that cannot be handled even by our own GSO.
>
> Reported-by: Wolfgang Walter <linux@stwm.de>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied and queued up for -stable, thanks Herbert.
prev parent reply other threads:[~2015-07-20 23:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-14 22:16 GRO: forwading ISATAP packets is very slow with kernel 4.1 Wolfgang Walter
2015-07-15 0:08 ` Herbert Xu
2015-07-15 0:34 ` Wolfgang Walter
2015-07-15 9:50 ` Herbert Xu
2015-07-15 12:25 ` Wolfgang Walter
2015-07-16 0:23 ` sit: Set SKB_GSO_SIT bit when performing GRO Herbert Xu
2015-07-16 10:58 ` Wolfgang Walter
2015-07-17 1:56 ` Herbert Xu
2015-07-17 15:38 ` Wolfgang Walter
2015-07-20 6:14 ` Herbert Xu
2015-07-20 9:39 ` Wolfgang Walter
2015-07-20 9:55 ` Revert "sit: Add gro callbacks to sit_offload" Herbert Xu
2015-07-20 23:53 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720.165329.259656303413900871.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux@stwm.de \
--cc=netdev@vger.kernel.org \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).