From: David Miller <davem@davemloft.net>
To: edjee@google.com
Cc: willemb@google.com, edumazet@google.com, hkchu@google.com,
netdev@vger.kernel.org
Subject: Re: [PATCH] inet: frags: fix defragmented packet's IP header for af_packet
Date: Mon, 20 Jul 2015 20:31:19 -0700 (PDT) [thread overview]
Message-ID: <20150720.203119.344614621480451223.davem@davemloft.net> (raw)
In-Reply-To: <1437036881-708-1-git-send-email-edjee@google.com>
From: Edward Jee <edjee@google.com>
Date: Thu, 16 Jul 2015 01:54:41 -0700
> When ip_frag_queue() computes positions, it assumes that the passed
> sk_buff does not contain L2 headers. However, when
> PACKET_FANOUT_FLAG_DEFRAG is used, IP defragmentation functions can be
> called on outgoing packets that contain L2 headers. Also, IPv4
> checksum is not corrected after defragmentation.
>
> Fixes: 7736d33f4262 ("packet: Add pre-defragmentation support for ipv4 fanouts.")
> Signed-off-by: Edward Hyunkoo Jee <edjee@google.com>
> Acked-by: Eric Dumazet <edumazet@google.com>
This doesn't compile.
net/ipv4/ip_fragment.c: In function ‘ip_frag_reasm’:
net/ipv4/ip_fragment.c:644:23: error: ‘skb’ undeclared (first use in this function)
ip_send_check(ip_hdr(skb));
^
net/ipv4/ip_fragment.c:644:23: note: each undeclared identifier is reported only once for each function it appears in
scripts/Makefile.build:258: recipe for target 'net/ipv4/ip_fragment.o' failed
make[1]: *** [net/ipv4/ip_fragment.o] Error 1
Makefile:1527: recipe for target 'net/ipv4/ip_fragment.o' failed
make: *** [net/ipv4/ip_fragment.o] Error 2
next prev parent reply other threads:[~2015-07-21 3:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-16 8:54 [PATCH] inet: frags: fix defragmented packet's IP header for af_packet Edward Jee
2015-07-21 3:31 ` David Miller [this message]
2015-07-21 7:29 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720.203119.344614621480451223.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=edjee@google.com \
--cc=edumazet@google.com \
--cc=hkchu@google.com \
--cc=netdev@vger.kernel.org \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).