Re: [PATCH net-next 15/22] route: Extend flow representation with tunnel key

[Thomas Graf <tgraf@suug.ch>]

On 07/17/15 at 11:25pm, Julian Anastasov wrote:
> 
> 	Hello,
> 
> On Fri, 17 Jul 2015, Thomas Graf wrote:
> 
> > Add a new flowi_tunnel structure which is a subset of ip_tunnel_key to
> > allow routes to match on tunnel metadata. For now, the tunnel id is
> > added to flowi_tunnel which allows for routes to be bound to specific
> > virtual tunnels.
> > 
> > Signed-off-by: Thomas Graf <tgraf@suug.ch>
> > ---
> 
> > +struct flowi_tunnel {
> > +	__be64			tun_id;
> > +};
> > +
> >  struct flowi_common {
> >  	int	flowic_oif;
> >  	int	flowic_iif;
> > @@ -30,6 +34,7 @@ struct flowi_common {
> >  #define FLOWI_FLAG_ANYSRC		0x01
> >  #define FLOWI_FLAG_KNOWN_NH		0x02
> >  	__u32	flowic_secid;
> > +	struct flowi_tunnel flowic_tun_key;
> 
> 	New input key for fib rules? It should be initialized
> at some places, we should not provide random values:

Good catch. I see several other fields uninitialized as well
but they only seemed used in the output path.