From: Stephen Hemminger <stephen@networkplumber.org>
To: Vadim Kochan <vadim4j@gmail.com>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH iproute2] ss: Fix crash when dump stats from /proc with '-p'
Date: Mon, 20 Jul 2015 13:43:40 -0700 [thread overview]
Message-ID: <20150720134340.6c7f8df7@urahara> (raw)
In-Reply-To: <1437421583-20999-1-git-send-email-vadim4j@gmail.com>
On Mon, 20 Jul 2015 22:46:23 +0300
Vadim Kochan <vadim4j@gmail.com> wrote:
> + if (s->name)
> + free(s->name);
Please don't add unnecessary conditional.
free(NULL) is defined to do nothing.
next prev parent reply other threads:[~2015-07-20 20:43 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 19:46 [PATCH iproute2] ss: Fix crash when dump stats from /proc with '-p' Vadim Kochan
2015-07-20 20:43 ` Stephen Hemminger [this message]
2015-07-21 4:45 ` Vadim Kochan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720134340.6c7f8df7@urahara \
--to=stephen@networkplumber.org \
--cc=netdev@vger.kernel.org \
--cc=vadim4j@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox