From: Andrew Lunn <andrew@lunn.ch>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: "David S. Miller" <davem@davemloft.net>,
Duan Andy <fugang.duan@freescale.com>,
Frank Li <Frank.Li@freescale.com>,
netdev@vger.kernel.org, kernel@pengutronix.de,
patchwork-lst@pengutronix.de
Subject: Re: [PATCH] net: fec: fix runtime PM when probing MII bus
Date: Mon, 20 Jul 2015 15:59:49 +0200 [thread overview]
Message-ID: <20150720135949.GC14842@lunn.ch> (raw)
In-Reply-To: <1437400094-11453-1-git-send-email-l.stach@pengutronix.de>
On Mon, Jul 20, 2015 at 03:48:14PM +0200, Lucas Stach wrote:
> In the case where there is no "mdio" bus specified in the devicetree a plain
> mdiobus_register() will be called, which tries to probe the connected PHY
> by doing mdio_read() on the bus.
> Since 6c3e921b18ed (net: fec: Ensure clocks are enabled while using mdio bus)
> this needs runtime PM to be available, but as RPM is only later set up in the
> FEC probe function those calls will fail, which in turn prevents the FEC
> driver to be registered successfully.
>
> Fix this by moving the RPM setup calls before the MII bus probing.
>
> Also move autosuspend init calls before runtime_pm_enable() so that the RPM
> callbacks aren't invoked several times during the probe function.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> The offending commit got in with v4.2-rc3, so this should be applied as
> a fix for 4.2.
Hi Lucas
The patch adding runtime PM has been reverted by David.
Are you O.K. if i fold you fix into my patch and resubmit. I will add
your Signed-off-by.
Thanks
Andrew
next prev parent reply other threads:[~2015-07-20 14:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 13:48 [PATCH] net: fec: fix runtime PM when probing MII bus Lucas Stach
2015-07-20 13:59 ` Andrew Lunn [this message]
2015-07-20 14:12 ` Lucas Stach
2015-07-20 23:52 ` Andrew Lunn
2015-07-21 0:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720135949.GC14842@lunn.ch \
--to=andrew@lunn.ch \
--cc=Frank.Li@freescale.com \
--cc=davem@davemloft.net \
--cc=fugang.duan@freescale.com \
--cc=kernel@pengutronix.de \
--cc=l.stach@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=patchwork-lst@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).