From: Stephen Hemminger <stephen@networkplumber.org>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: netdev@vger.kernel.org, eric.dumazet@gmail.com,
miham@beyondsemi.com, vadim4j@gmail.com, davem@davemloft.net
Subject: Re: [PATCH iproute2] ss: fix display of raw sockets
Date: Mon, 20 Jul 2015 14:58:39 -0700 [thread overview]
Message-ID: <20150720145839.79557d38@urahara> (raw)
In-Reply-To: <1436964642-35194-1-git-send-email-nikolay@cumulusnetworks.com>
On Wed, 15 Jul 2015 05:50:42 -0700
Nikolay Aleksandrov <nikolay@cumulusnetworks.com> wrote:
> After commit 8250bc9ff4e5 ("ss: Unify inet sockets output") raw sockets
> are displayed as udp because dgram_show_line() is used for both and
> thus IPPROTO_UDP is used for both so proto_name() returns "udp".
> Fix this by checking dg_proto which is set according to the caller of
> dgram_show_line().
>
> Reported-by: Miha Marolt <miham@beyondsemi.com>
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> ---
> note: use 0 instead of IPPROTO_RAW like Eric suggested
>
> misc/ss.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Applied, thanks.
next prev parent reply other threads:[~2015-07-20 21:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-09 14:13 [BUG] "$ ss -a" incorrectly displays raw sockets as udp sockets Miha Marolt
2015-07-09 14:50 ` Nikolay Aleksandrov
2015-07-09 14:55 ` Vadim Kochan
2015-07-09 14:57 ` Nikolay Aleksandrov
2015-07-09 15:09 ` Miha Marolt
2015-07-09 15:15 ` Vadim Kochan
2015-07-10 7:09 ` Miha Marolt
2015-07-10 7:16 ` Vadim Kochan
2015-07-15 12:10 ` Miha Marolt
2015-07-15 12:50 ` [PATCH iproute2] ss: fix display of raw sockets Nikolay Aleksandrov
2015-07-20 21:58 ` Stephen Hemminger [this message]
2015-07-09 15:14 ` [BUG] "$ ss -a" incorrectly displays raw sockets as udp sockets Eric Dumazet
2015-07-09 15:21 ` Eric Dumazet
2015-07-09 15:28 ` Vadim Kochan
2015-07-09 15:30 ` Nikolay Aleksandrov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720145839.79557d38@urahara \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=miham@beyondsemi.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=vadim4j@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox