From: Baruch Siach <baruch@tkos.co.il>
To: Cong Wang <cwang@twopensource.com>
Cc: "David S. Miller" <davem@davemloft.net>, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] net: vnet: relocate netlink code section comment
Date: Mon, 20 Jul 2015 20:12:52 +0300 [thread overview]
Message-ID: <20150720171252.GP13027@tarshish> (raw)
In-Reply-To: <CAHA+R7P63k8Fy+2fcXDdj1fKhYs+CUq=AihnoF7weM3ROnLnHA@mail.gmail.com>
Hi Cong Wang,
On Mon, Jul 20, 2015 at 10:07:00AM -0700, Cong Wang wrote:
> On Sun, Jul 19, 2015 at 12:40 AM, Baruch Siach <baruch@tkos.co.il> wrote:
> > The veth_setup() routine and the VETH_FEATURES macro are also part of the
> > netlink interface (referenced from struct rtnl_link_ops). Include them under
> > the netlink code section comment.
>
> Or just remove it? I don't think comment like this one is useful.
The veth.c file contain a few more separator comments. Would you suggest to
remove them all?
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
next prev parent reply other threads:[~2015-07-20 17:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-19 7:40 [PATCH] net: vnet: relocate netlink code section comment Baruch Siach
2015-07-20 17:07 ` Cong Wang
2015-07-20 17:12 ` Baruch Siach [this message]
2015-07-20 18:51 ` Cong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150720171252.GP13027@tarshish \
--to=baruch@tkos.co.il \
--cc=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).