[PATCH] net: vnet: relocate netlink code section comment

[PATCH] net: vnet: relocate netlink code section comment

[Baruch Siach]

The veth_setup() routine and the VETH_FEATURES macro are also part of the
netlink interface (referenced from struct rtnl_link_ops). Include them under
the netlink code section comment.

Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
 drivers/net/veth.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/veth.c b/drivers/net/veth.c
index c8186ffda1a3..791fc1e13bc4 100644
--- a/drivers/net/veth.c
+++ b/drivers/net/veth.c
@@ -292,6 +292,10 @@ static const struct net_device_ops veth_netdev_ops = {
 	.ndo_get_iflink		= veth_get_iflink,
 };
 
+/*
+ * netlink interface
+ */
+
 #define VETH_FEATURES (NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_ALL_TSO |    \
 		       NETIF_F_HW_CSUM | NETIF_F_RXCSUM | NETIF_F_HIGHDMA | \
 		       NETIF_F_GSO_GRE | NETIF_F_GSO_UDP_TUNNEL |	    \
@@ -321,10 +325,6 @@ static void veth_setup(struct net_device *dev)
 	dev->hw_enc_features = VETH_FEATURES;
 }
 
-/*
- * netlink interface
- */
-
 static int veth_validate(struct nlattr *tb[], struct nlattr *data[])
 {
 	if (tb[IFLA_ADDRESS]) {
-- 
2.1.4

Re: [PATCH] net: vnet: relocate netlink code section comment

[Cong Wang]

On Sun, Jul 19, 2015 at 12:40 AM, Baruch Siach <baruch@tkos.co.il> wrote:
> The veth_setup() routine and the VETH_FEATURES macro are also part of the
> netlink interface (referenced from struct rtnl_link_ops). Include them under
> the netlink code section comment.
>

Or just remove it? I don't think comment like this one is useful.

Re: [PATCH] net: vnet: relocate netlink code section comment

[Baruch Siach]

Hi Cong Wang,

On Mon, Jul 20, 2015 at 10:07:00AM -0700, Cong Wang wrote:
> On Sun, Jul 19, 2015 at 12:40 AM, Baruch Siach <baruch@tkos.co.il> wrote:
> > The veth_setup() routine and the VETH_FEATURES macro are also part of the
> > netlink interface (referenced from struct rtnl_link_ops). Include them under
> > the netlink code section comment.
> 
> Or just remove it? I don't think comment like this one is useful.

The veth.c file contain a few more separator comments. Would you suggest to 
remove them all?

baruch

-- 
     http://baruch.siach.name/blog/                  ~. .~   Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
   - baruch@tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -

Re: [PATCH] net: vnet: relocate netlink code section comment

[Cong Wang]

On Mon, Jul 20, 2015 at 10:12 AM, Baruch Siach <baruch@tkos.co.il> wrote:
> Hi Cong Wang,
>
> On Mon, Jul 20, 2015 at 10:07:00AM -0700, Cong Wang wrote:
>> On Sun, Jul 19, 2015 at 12:40 AM, Baruch Siach <baruch@tkos.co.il> wrote:
>> > The veth_setup() routine and the VETH_FEATURES macro are also part of the
>> > netlink interface (referenced from struct rtnl_link_ops). Include them under
>> > the netlink code section comment.
>>
>> Or just remove it? I don't think comment like this one is useful.
>
> The veth.c file contain a few more separator comments. Would you suggest to
> remove them all?
>

Yes, they look all useless for me myself.