From: David Miller <davem@davemloft.net>
To: fw@strlen.de
Cc: netdev@vger.kernel.org, kirill@shutemov.name,
cwang@twopensource.com, tgraf@suug.ch, kaber@trash.net
Subject: Re: [PATCH net] netlink: don't hold mutex in rcu callback when releasing mmapd ring
Date: Tue, 21 Jul 2015 22:23:22 -0700 (PDT) [thread overview]
Message-ID: <20150721.222322.1270246148178121431.davem@davemloft.net> (raw)
In-Reply-To: <1437489230-23542-1-git-send-email-fw@strlen.de>
From: Florian Westphal <fw@strlen.de>
Date: Tue, 21 Jul 2015 16:33:50 +0200
> Kirill A. Shutemov says:
>
> This simple test-case trigers few locking asserts in kernel:
...
> Cong Wang says:
>
> We can't hold mutex lock in a rcu callback, [..]
>
> Thomas Graf says:
>
> The socket should be dead at this point. It might be simpler to
> add a netlink_release_ring() function which doesn't require
> locking at all.
>
> Reported-by: "Kirill A. Shutemov" <kirill@shutemov.name>
> Diagnosed-by: Cong Wang <cwang@twopensource.com>
> Suggested-by: Thomas Graf <tgraf@suug.ch>
> Signed-off-by: Florian Westphal <fw@strlen.de>
Applied, thanks everyone.
prev parent reply other threads:[~2015-07-22 5:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 14:33 [PATCH net] netlink: don't hold mutex in rcu callback when releasing mmapd ring Florian Westphal
2015-07-22 5:23 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150721.222322.1270246148178121431.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=cwang@twopensource.com \
--cc=fw@strlen.de \
--cc=kaber@trash.net \
--cc=kirill@shutemov.name \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).