* [PATCH net-next] mpls_iptunnel: fix sparse warn: remove incorrect rcu_dereference
@ 2015-07-22 5:49 Roopa Prabhu
2015-07-22 17:50 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Roopa Prabhu @ 2015-07-22 5:49 UTC (permalink / raw)
To: davem; +Cc: netdev
From: Roopa Prabhu <roopa@cumulusnetworks.com>
fix for:
net/mpls/mpls_iptunnel.c:73:19: sparse: incompatible types in comparison
expression (different address spaces)
remove incorrect rcu_dereference possibly left over from
earlier revisions of the code.
Reported-by: kbuild test robot <fengguang.wu@intel.com>
Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
---
net/mpls/mpls_iptunnel.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/mpls/mpls_iptunnel.c b/net/mpls/mpls_iptunnel.c
index eea096f..276f8c9 100644
--- a/net/mpls/mpls_iptunnel.c
+++ b/net/mpls/mpls_iptunnel.c
@@ -70,7 +70,7 @@ int mpls_output(struct sock *sk, struct sk_buff *skb)
skb_orphan(skb);
/* Find the output device */
- out_dev = rcu_dereference(dst->dev);
+ out_dev = dst->dev;
if (!mpls_output_possible(out_dev) ||
!lwtstate || skb_warn_if_lro(skb))
goto drop;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] mpls_iptunnel: fix sparse warn: remove incorrect rcu_dereference
2015-07-22 5:49 [PATCH net-next] mpls_iptunnel: fix sparse warn: remove incorrect rcu_dereference Roopa Prabhu
@ 2015-07-22 17:50 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-07-22 17:50 UTC (permalink / raw)
To: roopa; +Cc: netdev
From: Roopa Prabhu <roopa@cumulusnetworks.com>
Date: Tue, 21 Jul 2015 22:49:00 -0700
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> fix for:
> net/mpls/mpls_iptunnel.c:73:19: sparse: incompatible types in comparison
> expression (different address spaces)
>
> remove incorrect rcu_dereference possibly left over from
> earlier revisions of the code.
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-07-22 17:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-22 5:49 [PATCH net-next] mpls_iptunnel: fix sparse warn: remove incorrect rcu_dereference Roopa Prabhu
2015-07-22 17:50 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).