From: Thomas Graf <tgraf@suug.ch>
To: Roopa Prabhu <roopa@cumulusnetworks.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] af_mpls: fix undefined reference to ip6_route_output
Date: Wed, 22 Jul 2015 14:23:09 +0200 [thread overview]
Message-ID: <20150722122309.GB968@pox.localdomain> (raw)
In-Reply-To: <1437549003-35563-1-git-send-email-roopa@cumulusnetworks.com>
On 07/22/15 at 12:10am, Roopa Prabhu wrote:
> From: Roopa Prabhu <roopa@cumulusnetworks.com>
>
> seen with CONFIG_IPV6 disabled. Wrap the code
> around IS_ENABLED(CONFIG_IPV6)
>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> Signed-off-by: Roopa Prabhu <roopa@cumulusnetworks.com>
We need the same for CONFIG_INET=n in inet_fib_lookup_dev:
/home/tgraf/dev/linux/net-next/include/net/route.h:122: undefined reference to `ip_route_output_flow'
Is it worth returning EAFNOSUPPORT instead of ENODEV in these
cases? Something like this:
> }
> +#else
> +static struct net_device *inet6_fib_lookup_dev(struct net *net, void *addr)
> +{
+ return ERR_PTR(-EAFNOSUPPORT);
> +}
> +#endif
And then IS_ERR() in mpls_route_add()?
next prev parent reply other threads:[~2015-07-22 12:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 7:10 [PATCH net-next] af_mpls: fix undefined reference to ip6_route_output Roopa Prabhu
2015-07-22 12:23 ` Thomas Graf [this message]
2015-07-22 17:49 ` David Miller
2015-07-22 19:30 ` roopa
2015-07-22 19:57 ` Thomas Graf
2015-07-22 20:04 ` David Miller
2015-07-22 20:17 ` Thomas Graf
2015-07-22 20:38 ` roopa
2015-07-23 7:09 ` David Miller
2015-07-23 13:44 ` roopa
2015-07-27 0:20 ` David Miller
2015-07-22 20:22 ` roopa
2015-07-22 20:03 ` David Miller
2015-07-22 19:30 ` roopa
-- strict thread matches above, loose matches on Subject: below --
2015-07-22 23:10 Roopa Prabhu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150722122309.GB968@pox.localdomain \
--to=tgraf@suug.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox