* [PATCH] virtio_net: don't require ANY_LAYOUT with VERSION_1
@ 2015-07-15 12:26 Michael S. Tsirkin
2015-07-15 12:55 ` [virtio-dev] " Paolo Bonzini
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Michael S. Tsirkin @ 2015-07-15 12:26 UTC (permalink / raw)
To: linux-kernel; +Cc: virtualization, netdev, Jason Wang, virtio-dev
ANY_LAYOUT is a compatibility feature. It's implied
for VERSION_1 devices, and non-transitional devices
might not offer it. Change code to behave accordingly.
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
drivers/net/virtio_net.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index 63c7810..7fbca37 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -1828,7 +1828,8 @@ static int virtnet_probe(struct virtio_device *vdev)
else
vi->hdr_len = sizeof(struct virtio_net_hdr);
- if (virtio_has_feature(vdev, VIRTIO_F_ANY_LAYOUT))
+ if (virtio_has_feature(vdev, VIRTIO_F_ANY_LAYOUT) ||
+ virtio_has_feature(vdev, VIRTIO_F_VERSION_1))
vi->any_header_sg = true;
if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ))
--
MST
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [virtio-dev] [PATCH] virtio_net: don't require ANY_LAYOUT with VERSION_1
2015-07-15 12:26 [PATCH] virtio_net: don't require ANY_LAYOUT with VERSION_1 Michael S. Tsirkin
@ 2015-07-15 12:55 ` Paolo Bonzini
2015-07-16 10:29 ` Stefan Hajnoczi
2015-07-20 19:42 ` David Miller
2 siblings, 0 replies; 5+ messages in thread
From: Paolo Bonzini @ 2015-07-15 12:55 UTC (permalink / raw)
To: Michael S. Tsirkin, linux-kernel; +Cc: netdev, virtio-dev, virtualization
On 15/07/2015 14:26, Michael S. Tsirkin wrote:
> ANY_LAYOUT is a compatibility feature. It's implied
> for VERSION_1 devices, and non-transitional devices
> might not offer it. Change code to behave accordingly.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/net/virtio_net.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 63c7810..7fbca37 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -1828,7 +1828,8 @@ static int virtnet_probe(struct virtio_device *vdev)
> else
> vi->hdr_len = sizeof(struct virtio_net_hdr);
>
> - if (virtio_has_feature(vdev, VIRTIO_F_ANY_LAYOUT))
> + if (virtio_has_feature(vdev, VIRTIO_F_ANY_LAYOUT) ||
> + virtio_has_feature(vdev, VIRTIO_F_VERSION_1))
> vi->any_header_sg = true;
>
> if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ))
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [virtio-dev] [PATCH] virtio_net: don't require ANY_LAYOUT with VERSION_1
2015-07-15 12:26 [PATCH] virtio_net: don't require ANY_LAYOUT with VERSION_1 Michael S. Tsirkin
2015-07-15 12:55 ` [virtio-dev] " Paolo Bonzini
@ 2015-07-16 10:29 ` Stefan Hajnoczi
2015-07-20 19:42 ` David Miller
2 siblings, 0 replies; 5+ messages in thread
From: Stefan Hajnoczi @ 2015-07-16 10:29 UTC (permalink / raw)
To: Michael S. Tsirkin
Cc: linux-kernel, virtualization, netdev, Jason Wang, virtio-dev
[-- Attachment #1: Type: text/plain, Size: 444 bytes --]
On Wed, Jul 15, 2015 at 03:26:19PM +0300, Michael S. Tsirkin wrote:
> ANY_LAYOUT is a compatibility feature. It's implied
> for VERSION_1 devices, and non-transitional devices
> might not offer it. Change code to behave accordingly.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/net/virtio_net.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: Type: application/pgp-signature, Size: 473 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] virtio_net: don't require ANY_LAYOUT with VERSION_1
2015-07-15 12:26 [PATCH] virtio_net: don't require ANY_LAYOUT with VERSION_1 Michael S. Tsirkin
2015-07-15 12:55 ` [virtio-dev] " Paolo Bonzini
2015-07-16 10:29 ` Stefan Hajnoczi
@ 2015-07-20 19:42 ` David Miller
2015-07-22 10:08 ` Michael S. Tsirkin
2 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2015-07-20 19:42 UTC (permalink / raw)
To: mst; +Cc: netdev, virtio-dev, linux-kernel, virtualization
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Wed, 15 Jul 2015 15:26:19 +0300
> ANY_LAYOUT is a compatibility feature. It's implied
> for VERSION_1 devices, and non-transitional devices
> might not offer it. Change code to behave accordingly.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] virtio_net: don't require ANY_LAYOUT with VERSION_1
2015-07-20 19:42 ` David Miller
@ 2015-07-22 10:08 ` Michael S. Tsirkin
0 siblings, 0 replies; 5+ messages in thread
From: Michael S. Tsirkin @ 2015-07-22 10:08 UTC (permalink / raw)
To: David Miller; +Cc: linux-kernel, virtualization, netdev, jasowang, virtio-dev
On Mon, Jul 20, 2015 at 12:42:59PM -0700, David Miller wrote:
> From: "Michael S. Tsirkin" <mst@redhat.com>
> Date: Wed, 15 Jul 2015 15:26:19 +0300
>
> > ANY_LAYOUT is a compatibility feature. It's implied
> > for VERSION_1 devices, and non-transitional devices
> > might not offer it. Change code to behave accordingly.
> >
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> Applied.
Thanks!
Please also forward this to stable as it's a spec
compliance question.
--
MST
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-07-22 10:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-07-15 12:26 [PATCH] virtio_net: don't require ANY_LAYOUT with VERSION_1 Michael S. Tsirkin
2015-07-15 12:55 ` [virtio-dev] " Paolo Bonzini
2015-07-16 10:29 ` Stefan Hajnoczi
2015-07-20 19:42 ` David Miller
2015-07-22 10:08 ` Michael S. Tsirkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).