From: Martin KaFai Lau <kafai@fb.com>
To: YOSHIFUJI Hideaki <hideaki.yoshifuji@miraclelinux.com>
Cc: netdev <netdev@vger.kernel.org>, Kernel Team <kernel-team@fb.com>,
Hannes Frederic Sowa <hannes@stressinduktion.org>
Subject: Re: [PATCH net-next] ipv6: Avoid rt6_probe() taking writer lock in the fast path
Date: Wed, 22 Jul 2015 11:43:29 -0700 [thread overview]
Message-ID: <20150722184328.GB2832181@devbig242.prn2.facebook.com> (raw)
In-Reply-To: <55AEFBB3.1010503@miraclelinux.com>
On Wed, Jul 22, 2015 at 11:10:59AM +0900, YOSHIFUJI Hideaki wrote:
> You have to take "some" lock when accessing neigh->nud_state
> theoretically.
I don't think read_lock can buy us a lot of extra protection either.
If it has missed the train, the next ip6_pol_route() call will
trigger rt6_probe(). There are other places checking nud_state without
lock also.
Thanks,
--Martin
next prev parent reply other threads:[~2015-07-22 18:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-21 23:51 [PATCH net-next] ipv6: Avoid rt6_probe() taking writer lock in the fast path Martin KaFai Lau
2015-07-22 2:10 ` YOSHIFUJI Hideaki
2015-07-22 18:43 ` Martin KaFai Lau [this message]
2015-07-22 4:19 ` Julian Anastasov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150722184328.GB2832181@devbig242.prn2.facebook.com \
--to=kafai@fb.com \
--cc=hannes@stressinduktion.org \
--cc=hideaki.yoshifuji@miraclelinux.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).