From: David Miller <davem@davemloft.net>
To: fw@strlen.de
Cc: netdev@vger.kernel.org, johan@transip.nl, fschreuder@transip.nl,
nikolay@cumulusnetworks.com
Subject: Re: [PATCH net 0/4] inet: ip defrag bug fixes
Date: Sun, 26 Jul 2015 21:00:36 -0700 (PDT) [thread overview]
Message-ID: <20150726.210036.2175646567443197922.davem@davemloft.net> (raw)
In-Reply-To: <1437645940-7895-1-git-send-email-fw@strlen.de>
From: Florian Westphal <fw@strlen.de>
Date: Thu, 23 Jul 2015 12:05:36 +0200
> Johan Schuijt and Frank Schreuder reported crash and softlockup after the
> inet workqueue eviction change:
>
> general protection fault: 0000 [#1] SMP
> CPU: 0 PID: 4 Comm: kworker/0:0 Not tainted 3.18.18-transip-1.5 #1
> Workqueue: events inet_frag_worker
> task: ffff880224935130 ti: ffff880224938000 task.ti: ffff880224938000
> RIP: 0010:[<ffffffff8149288c>] [<ffffffff8149288c>] inet_evict_bucket+0xfc/0x160
> RSP: 0018:ffff88022493bd58 EFLAGS: 00010286
> RAX: ffff88021f4f3e80 RBX: dead000000100100 RCX: 000000000000006b
> RDX: 000000000000006c RSI: ffff88021f4f3e80 RDI: dead0000001000a8
> RBP: 0000000000000002 R08: ffff880222273900 R09: ffff880036e49200
> R10: ffff8800c6e86500 R11: ffff880036f45500 R12: ffffffff81a87100
> R13: ffff88022493bd70 R14: 0000000000000000 R15: ffff8800c9b26280
> [..]
> Call Trace:
> [<ffffffff814929e0>] ? inet_frag_worker+0x60/0x210
> [<ffffffff8107e3a2>] ? process_one_work+0x142/0x3b0
> [<ffffffff8107eb94>] ? worker_thread+0x114/0x440
> [..]
>
> A second issue results in softlockup since the evictor may restart the
> eviction loop for a (potentially) unlimited number of times while local
> softirqs are disabled.
>
> Frank reports that test system remained stable for 14 hours of testing
> (before, crash occured within half an hour in their setup).
Looks great, series applied, thanks everyone.
prev parent reply other threads:[~2015-07-27 4:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-23 10:05 [PATCH net 0/4] inet: ip defrag bug fixes Florian Westphal
2015-07-23 10:05 ` [PATCH net 1/4] inet: frag: don't re-use chainlist for evictor Florian Westphal
2015-07-23 10:05 ` [PATCH net 2/4] inet: frag: change *_frag_mem_limit functions to take netns_frags as argument Florian Westphal
2015-07-23 10:05 ` [PATCH net 3/4] inet: frag: don't wait for timer deletion when evicting Florian Westphal
2015-07-23 10:05 ` [PATCH net 4/4] inet: frags: remove INET_FRAG_EVICTED and use list_evictor for the test Florian Westphal
2015-07-27 4:00 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150726.210036.2175646567443197922.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=fschreuder@transip.nl \
--cc=fw@strlen.de \
--cc=johan@transip.nl \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).