From: David Miller <davem@davemloft.net>
To: sd@queasysnail.net
Cc: netdev@vger.kernel.org, rh-bugzilla@ensc.de, dan@censornet.com
Subject: Re: [PATCH net] tcp: fix recv with flags MSG_WAITALL | MSG_PEEK
Date: Mon, 27 Jul 2015 01:07:18 -0700 (PDT) [thread overview]
Message-ID: <20150727.010718.1993487512103673653.davem@davemloft.net> (raw)
In-Reply-To: <20150724161925.GA12489@bistromath.redhat.com>
From: Sabrina Dubroca <sd@queasysnail.net>
Date: Fri, 24 Jul 2015 18:19:25 +0200
> Currently, tcp_recvmsg enters a busy loop in sk_wait_data if called
> with flags = MSG_WAITALL | MSG_PEEK.
>
> sk_wait_data waits for sk_receive_queue not empty, but in this case,
> the receive queue is not empty, but does not contain any skb that we
> can use.
>
> Add a "last skb seen on receive queue" argument to sk_wait_data, so
> that it sleeps until the receive queue has new skbs.
>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=99461
> Link: https://sourceware.org/bugzilla/show_bug.cgi?id=18493
> Link: https://bugzilla.redhat.com/show_bug.cgi?id=1205258
> Reported-by: Enrico Scholz <rh-bugzilla@ensc.de>
> Reported-by: Dan Searle <dan@censornet.com>
> Signed-off-by: Sabrina Dubroca <sd@queasysnail.net>
Applied, thanks.
prev parent reply other threads:[~2015-07-27 8:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 16:19 [PATCH net] tcp: fix recv with flags MSG_WAITALL | MSG_PEEK Sabrina Dubroca
2015-07-24 17:05 ` Eric Dumazet
2015-07-27 8:07 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150727.010718.1993487512103673653.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dan@censornet.com \
--cc=netdev@vger.kernel.org \
--cc=rh-bugzilla@ensc.de \
--cc=sd@queasysnail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).