netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: nikolay@cumulusnetworks.com
Cc: netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
	stephen@networkplumber.org, razor@blackwall.org,
	sashok@cumulusnetworks.com
Subject: Re: [PATCH net v2] bridge: stp: when using userspace stp stop kernel hello and hold timers
Date: Tue, 28 Jul 2015 23:33:33 -0700 (PDT)	[thread overview]
Message-ID: <20150728.233333.793723681312359738.davem@davemloft.net> (raw)
In-Reply-To: <1437674465-4388-1-git-send-email-nikolay@cumulusnetworks.com>

From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Date: Thu, 23 Jul 2015 11:01:05 -0700

> From: Nikolay Aleksandrov <razor@blackwall.org>
> 
> These should be handled only by the respective STP which is in control.
> They become problematic for devices with limited resources with many
> ports because the hold_timer is per port and fires each second and the
> hello timer fires each 2 seconds even though it's global. While in
> user-space STP mode these timers are completely unnecessary so it's better
> to keep them off.
> Also ensure that when the bridge is up these timers are started only when
> running with kernel STP.
> 
> Signed-off-by: Satish Ashok <sashok@cumulusnetworks.com>
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>

Applied, thanks.

      reply	other threads:[~2015-07-29  6:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-23 16:07 [PATCH net] bridge: stp: when using userspace stp stop kernel hello and hold timers Nikolay Aleksandrov
2015-07-23 16:59 ` Stephen Hemminger
2015-07-23 17:05   ` Nikolay Aleksandrov
2015-07-23 17:13     ` Stephen Hemminger
2015-07-23 17:31       ` Nikolay Aleksandrov
2015-07-23 18:01 ` [PATCH net v2] " Nikolay Aleksandrov
2015-07-29  6:33   ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150728.233333.793723681312359738.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=bridge@lists.linux-foundation.org \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=razor@blackwall.org \
    --cc=sashok@cumulusnetworks.com \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).