From: David Miller <davem@davemloft.net>
To: corcodel.marian@gmail.com
Cc: netdev@vger.kernel.org, romieu@fr.zoreil.com
Subject: Re: [PATCH net-next] r8169:Place dma_alloc_coherent on interrupt context
Date: Thu, 30 Jul 2015 13:45:25 -0700 (PDT) [thread overview]
Message-ID: <20150730.134525.824837450657122732.davem@davemloft.net> (raw)
In-Reply-To: <1438284801-4188-1-git-send-email-corcodel.marian@gmail.com>
From: Corcodel Marian <corcodel.marian@gmail.com>
Date: Thu, 30 Jul 2015 22:33:21 +0300
> According to this doc
> https://www.kernel.org/doc/Documentation/DMA-API.txt dma_alloc_coherent
> must run on interrupt context, and flush the chip before use.
>
> Signed-off-by: Corcodel Marian <corcodel.marian@gmail.com>
>
> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 3df51fa..edce264 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -7535,15 +7535,15 @@ static void rtl8169_down(struct net_device *dev)
> rtl_pll_power_down(tp);
> }
>
> -static int rtl8169_close(struct net_device *dev)
> +/*static int rtl8169_close(struct net_device *dev)
This really isn't acceptable.
next prev parent reply other threads:[~2015-07-30 20:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 19:33 [PATCH net-next] r8169:Place dma_alloc_coherent on interrupt context Corcodel Marian
2015-07-30 20:45 ` David Miller [this message]
2015-07-30 20:59 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150730.134525.824837450657122732.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=corcodel.marian@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox