From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: David Ahern <dsahern@gmail.com>
Cc: netdev@vger.kernel.org, cwang@twopensource.com,
ajaykumar.hotchandani@oracle.com
Subject: Re: [PATCH RFC net-next 1/3] RDS-TCP: Make RDS-TCP work correctly when it is set up in a netns other than init_net
Date: Thu, 30 Jul 2015 19:58:57 +0200 [thread overview]
Message-ID: <20150730175857.GA20426@oracle.com> (raw)
In-Reply-To: <55BA58D1.3050108@gmail.com>
On (07/30/15 11:03), David Ahern wrote:
> >+ write_pnet(&conn->c_net, net);
>
> these are typically in wrappers like sock_net and sock_net_set
:
> >+ conn = rds_conn_create(&init_net, dp->dp_daddr, dp->dp_saddr,
> >+ &rds_ib_transport, GFP_KERNEL);
>
> I forget what connection this is -- control channel?
this is IB. It should/will eventually also use any net than init_net,
but for the moment, I'd like to figure out the bigger issue
of pernet vs per_subsys, which is harder to fix than the above
(and which I'll happily fix later).
I suspect that the right solution may be to have some notifier
callbacks in rds_tcp that listen for ifdown and tear down the sockets,
rather than wait for keepalive timeout.
> Ditto here.
yes, me too.
--Sowmini
next prev parent reply other threads:[~2015-07-30 17:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 8:55 [PATCH RFC net-next 0/3] RDS-TCP: Network namespace support Sowmini Varadhan
2015-07-30 8:55 ` [PATCH RFC net-next 1/3] RDS-TCP: Make RDS-TCP work correctly when it is set up in a netns other than init_net Sowmini Varadhan
2015-07-30 17:03 ` David Ahern
2015-07-30 17:58 ` Sowmini Varadhan [this message]
2015-07-30 8:55 ` [PATCH RFC net-next 2/3] RDS-TCP: Support multiple RDS-TCP listen endpoints, one per netns Sowmini Varadhan
2015-07-30 8:55 ` [PATCH RFC net-next 3/3] net/core/sock.c: sk_clone_lock() should only do get_net() if the parent is not a kernel socket Sowmini Varadhan
2015-07-30 13:06 ` Eric Dumazet
2015-07-30 18:29 ` Cong Wang
2015-07-30 21:31 ` Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150730175857.GA20426@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=ajaykumar.hotchandani@oracle.com \
--cc=cwang@twopensource.com \
--cc=dsahern@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).