From: David Miller <davem@davemloft.net>
To: nathan.sullivan@ni.com
Cc: f.fainelli@gmail.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] net/phy: micrel: Reenable interrupts during resume
Date: Fri, 31 Jul 2015 13:21:29 -0700 (PDT) [thread overview]
Message-ID: <20150731.132129.1623811034601507745.davem@davemloft.net> (raw)
In-Reply-To: <20150731142706.GA11442@nathan3500-linux-VM>
From: Nathan Sullivan <nathan.sullivan@ni.com>
Date: Fri, 31 Jul 2015 09:27:06 -0500
> I believe I found the issue, we are using this PHY with cadence macb as
> the MAC. The driver currently turns off the management port in
> macb_reset_hw, which we have stopped with a local change since our hardware
> typically has multiple phys on one mdio bus. That also prevents phy suspend
> from working correctly, since the bus goes down before the phy state machine
> can stop the phy.
>
> In our local patch, we have macb_reset_hw keep the mdio bus on if it's on
> already. Does that sound like an acceptable fix to you?
Then you don't need this patch at all if your hardware configuration
in question will not suspend the PHY device.
Can you see how rediculous this situation looks to me?
You can't even test this change on the hardware you are using.
next prev parent reply other threads:[~2015-07-31 20:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 15:15 [PATCH v2] net/phy: micrel: Reenable interrupts during resume Nathan Sullivan
2015-07-30 16:40 ` Florian Fainelli
2015-07-30 17:00 ` David Miller
2015-07-30 23:09 ` Nathan Sullivan
2015-07-31 7:22 ` David Miller
2015-07-31 14:27 ` Nathan Sullivan
2015-07-31 20:21 ` David Miller [this message]
2015-07-30 18:00 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150731.132129.1623811034601507745.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nathan.sullivan@ni.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).