From: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
To: Or Gerlitz <gerlitz.or@gmail.com>
Cc: Doug Ledford <dledford@redhat.com>,
Matan Barak <matanb@mellanox.com>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Sean Hefty <sean.hefty@intel.com>,
Somnath Kotur <Somnath.Kotur@avagotech.com>,
Moni Shoua <monis@mellanox.com>,
"talal@mellanox.com" <talal@mellanox.com>,
Haggai Eran <haggaie@mellanox.com>,
Linux Netdev List <netdev@vger.kernel.org>
Subject: Re: [PATCH for-next V7 00/10] Move RoCE GID management to IB/Core
Date: Fri, 31 Jul 2015 16:01:02 -0600 [thread overview]
Message-ID: <20150731220102.GA31209@obsidianresearch.com> (raw)
In-Reply-To: <CAJ3xEMiP57qf58B=VHRazs50RC5r-7OsUPb=GV1kBQ6vu6Tqjw@mail.gmail.com>
On Sat, Aug 01, 2015 at 12:24:23AM +0300, Or Gerlitz wrote:
> addressed in incremental patch, as Doug suggested. Jason, it's wrong
> to send developers again and again to fix things which were
> perfect in Vn-1 but also not being covered by reviewers on Vn-1, at
> some point the reviewer can't load new comments which gate the
I don't even know what you are talking about Or.
v6 had some small problems in the logic and v7 introduces a fairly
serious flaw while trying to fix them. IMHO, you are better to merge
v6 than v7, at least v6's problems are less likely to be serious.
IMHO, it took until around v5/v6 before this series was even worth
taking a detailed look at. I'm certainly not willing to waste my time
doing detailed reviews on other elements when basic things like
locking and refcounting are screwed up.
I think you are really off side with the idea that a review has to see
every problem in Vn or ignore it in Vn+1. That is obviously
unworkable.
> acceptance but rather be willing for things to be fixed incrementally.
That is the same argument you used for the timestamp _ex UAPI mess,
last cycle, where are the incremental fixes for that?
Jason
next prev parent reply other threads:[~2015-07-31 22:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 15:33 [PATCH for-next V7 00/10] Move RoCE GID management to IB/Core Matan Barak
2015-07-30 15:33 ` [PATCH for-next V7 01/10] net/ipv6: Export addrconf_ifid_eui48 Matan Barak
2015-07-30 15:33 ` [PATCH for-next V7 02/10] net: Add info for NETDEV_CHANGEUPPER event Matan Barak
[not found] ` <1438270411-17648-1-git-send-email-matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-07-30 15:33 ` [PATCH for-next V7 03/10] net/bonding: Export bond_option_active_slave_get_rcu Matan Barak
2015-07-31 9:40 ` [PATCH for-next V7 00/10] Move RoCE GID management to IB/Core Or Gerlitz
[not found] ` <CAJ3xEMh9z=LG7dW0nBP8Zdrbf0SkZ_GCxjCoowWXuw2dueN+xg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-31 12:50 ` Doug Ledford
[not found] ` <55BB6F10.5030408-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-07-31 16:32 ` Jason Gunthorpe
[not found] ` <20150731163201.GA6027-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-07-31 17:41 ` Doug Ledford
[not found] ` <55BBB353.7020806-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2015-07-31 20:18 ` Jason Gunthorpe
[not found] ` <20150731201828.GA28263-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-08-01 0:30 ` Doug Ledford
[not found] ` <be961828-39ff-4a15-863e-93cc86dfcf49@email.android.com>
[not found] ` <be961828-39ff-4a15-863e-93cc86dfcf49-2ueSQiBKiTY7tOexoI0I+QC/G2K4zDHf@public.gmane.org>
2015-08-02 3:03 ` Jason Gunthorpe
2015-07-31 21:24 ` Or Gerlitz
2015-07-31 22:01 ` Jason Gunthorpe [this message]
2015-08-01 21:48 ` Or Gerlitz
[not found] ` <CAJ3xEMjgvgvc8WyUhHagiH4gNs6KK7pL_TmhXCywNiWEy4p70w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-08-02 7:56 ` Matan Barak
[not found] ` <55BDCD36.6000301-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-08-06 4:53 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150731220102.GA31209@obsidianresearch.com \
--to=jgunthorpe@obsidianresearch.com \
--cc=Somnath.Kotur@avagotech.com \
--cc=dledford@redhat.com \
--cc=gerlitz.or@gmail.com \
--cc=haggaie@mellanox.com \
--cc=linux-rdma@vger.kernel.org \
--cc=matanb@mellanox.com \
--cc=monis@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=sean.hefty@intel.com \
--cc=talal@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).