From: Dan Carpenter <dan.carpenter@oracle.com>
To: roopa@cumulusnetworks.com
Cc: "Eric W. Biederman" <ebiederm@xmission.com>, netdev@vger.kernel.org
Subject: re: af_mpls: fix undefined reference to ip6_route_output
Date: Tue, 4 Aug 2015 10:44:02 +0300 [thread overview]
Message-ID: <20150804074402.GA10867@mwanda> (raw)
Hello Roopa,
I have a concern about patch bf21563acc1d: "af_mpls: fix undefined
reference to ip6_route_output" from Jul 30, 2015.
net/mpls/af_mpls.c
450
451 dev = find_outdev(net, cfg);
452 if (IS_ERR(dev)) {
find_outdev() used to return NULL pointers but now it only returns NULL
if cfg->rc_via_table == NEIGH_LINK_TABLE or dev_get_by_index() fails.
I think it could lead to a NULL dereference and we don't check for that
here.
Returning a mix of error pointers and NULL is bad style, it needs a big
comment at the top of the function if it's deliberate.
453 err = PTR_ERR(dev);
454 dev = NULL;
455 goto errout;
456 }
regards,
dan carpenter
next reply other threads:[~2015-08-04 7:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-04 7:44 Dan Carpenter [this message]
2015-08-04 13:39 ` af_mpls: fix undefined reference to ip6_route_output roopa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150804074402.GA10867@mwanda \
--to=dan.carpenter@oracle.com \
--cc=ebiederm@xmission.com \
--cc=netdev@vger.kernel.org \
--cc=roopa@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).