netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: Liviu.Dudau@arm.com
Cc: mlindner@marvell.com, stephen@networkplumber.org,
	ryan.harkin@linaro.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sky2: Add module parameter for passing the MAC address
Date: Wed, 05 Aug 2015 17:32:33 -0700 (PDT)	[thread overview]
Message-ID: <20150805.173233.539752020022715092.davem@davemloft.net> (raw)
In-Reply-To: <1438789854-29194-1-git-send-email-Liviu.Dudau@arm.com>

From: Liviu Dudau <Liviu.Dudau@arm.com>
Date: Wed,  5 Aug 2015 16:50:54 +0100

> For designs where EEPROMs are not connected to PCI Yukon2
> chips we need to get the MAC address from the firmware.
> Add a module parameter called 'mac_address' for this. It
> will be used if no DT node can be found and the B2_MAC
> register holds an invalid value.
> 
> Signed-off-by: Liviu Dudau <Liviu.Dudau@arm.com>

Sorry, such module options are absolutely not allowed.

If an invalid MAC is present, it should be set to a random
one via eth_random_addr().

  parent reply	other threads:[~2015-08-06  0:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-05 15:50 [PATCH] sky2: Add module parameter for passing the MAC address Liviu Dudau
2015-08-05 16:40 ` Stephen Hemminger
2015-08-05 17:16   ` Liviu Dudau
2015-08-05 20:33     ` Francois Romieu
2015-08-05 23:16       ` Stephen Hemminger
2015-08-06  0:33         ` Florian Fainelli
2015-08-11 14:35           ` [PATCH v2 net-next] sky2: use random address if EEPROM is bad Liviu Dudau
2015-08-11 17:01             ` Stephen Hemminger
2015-08-12  9:30               ` Liviu Dudau
2015-08-12 15:28                 ` Stephen Hemminger
2015-08-12 16:00                   ` Liviu Dudau
2015-08-11 18:56             ` Sergei Shtylyov
2015-08-12  9:15               ` Liviu Dudau
     [not found] ` <CAD0U-h+Lbz+bygVCaF1Ji0VPLfh9sn504rCeGigXLER+H=KnZg@mail.gmail.com>
2015-08-05 17:18   ` [PATCH] sky2: Add module parameter for passing the MAC address Liviu Dudau
2015-08-06  0:32 ` David Miller [this message]
2015-08-06 10:31   ` Liviu Dudau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150805.173233.539752020022715092.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Liviu.Dudau@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mlindner@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=ryan.harkin@linaro.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).