netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Graf <tgraf@suug.ch>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Daniel Borkmann <daniel@iogearbox.net>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Jiri Pirko <jiri@resnulli.us>, Cong Wang <cwang@twopensource.com>,
	David Miller <davem@davemloft.net>,
	Nicolas Dichtel <nicolas.dichtel@6wind.com>,
	Scott Feldman <sfeldma@gmail.com>,
	Network Development <netdev@vger.kernel.org>
Subject: Re: rtnl_mutex deadlock?
Date: Sat, 8 Aug 2015 19:22:41 +0200	[thread overview]
Message-ID: <20150808172241.GA15145@pox.localdomain> (raw)
In-Reply-To: <20150807000015.GA22952@gondor.apana.org.au>

On 08/07/15 at 08:00am, Herbert Xu wrote:
> On Fri, Aug 07, 2015 at 01:58:15AM +0200, Daniel Borkmann wrote:
> >
> > Looks like we had a WARN_ON() in rhashtable_insert_rehash() before, but
> > was removed in a87b9ebf1709 ("rhashtable: Do not schedule more than one
> > rehash if we can't grow further"). Do you want to re-add a WARN_ON_ONCE()?
> 
> I think so.  Thomas?

Makes sense. I removed it because I thought it was not possible to
reach.

  reply	other threads:[~2015-08-08 17:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-04 15:48 rtnl_mutex deadlock? Linus Torvalds
2015-08-05  5:31 ` Cong Wang
2015-08-05  7:43   ` Jiri Pirko
2015-08-05  8:44     ` Linus Torvalds
2015-08-05 18:59       ` Daniel Borkmann
2015-08-06  0:30         ` Herbert Xu
2015-08-06 14:50           ` Daniel Borkmann
2015-08-06 22:39             ` Daniel Borkmann
2015-08-06 23:42               ` Herbert Xu
2015-08-06 23:41             ` Herbert Xu
2015-08-06 23:58               ` Daniel Borkmann
2015-08-07  0:00                 ` Herbert Xu
2015-08-08 17:22                   ` Thomas Graf [this message]
2015-08-06  5:19         ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150808172241.GA15145@pox.localdomain \
    --to=tgraf@suug.ch \
    --cc=cwang@twopensource.com \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=jiri@resnulli.us \
    --cc=netdev@vger.kernel.org \
    --cc=nicolas.dichtel@6wind.com \
    --cc=sfeldma@gmail.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).