From: David Miller <davem@davemloft.net>
To: yalin.wang2010@gmail.com
Cc: joe@perches.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 Resend] net/fddi: remove HWM_REVERSE() macro
Date: Mon, 10 Aug 2015 22:37:50 -0700 (PDT) [thread overview]
Message-ID: <20150810.223750.1908561238664673104.davem@davemloft.net> (raw)
In-Reply-To: <39055924-5AA5-4DE0-8872-D2F107EA82F1@gmail.com>
From: yalin wang <yalin.wang2010@gmail.com>
Date: Tue, 11 Aug 2015 13:11:22 +0800
> HWM_REVERSE() macro is unused, remove it.
>
> Signed-off-by: yalin wang <yalin.wang2010@gmail.com>
You did not do as I asked you to, this patch is still corrupted
and there is no way you successfully applied what is in this patch.
> -#define HWM_REVERSE(x) ((((x)<<24L)&0xff000000L) + \
> - (((x)<< 8L)&0x00ff0000L) + \
> - (((x)>> 8L)&0x0000ff00L) + \
> - (((x)>>24L)&0x000000ffL))
This indentation here is spaces, whereas in the source files they
are TABS.
Your email client did this.
If you fail to properly verify that your outgoing patches are not
corrupted before submitting them here, I will stop reviewing and
considering your changes.
Thank you.
next prev parent reply other threads:[~2015-08-11 5:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-10 16:14 [PATCH] net/fddi:change HWM_REVERSE() macro yalin wang
2015-08-10 16:36 ` Joe Perches
2015-08-11 1:40 ` yalin wang
2015-08-11 1:57 ` [PATCH v2] net/fddi: remove " yalin wang
2015-08-11 4:24 ` David Miller
2015-08-11 5:06 ` yalin wang
2015-08-11 5:11 ` [PATCH v2 Resend] " yalin wang
2015-08-11 5:37 ` David Miller [this message]
2015-08-11 5:50 ` yalin wang
2015-08-11 6:57 ` yalin wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150810.223750.1908561238664673104.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yalin.wang2010@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).