From: Glenn Griffin <ggriffin.kernel@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: pshelar@nicira.com, netdev@vger.kernel.org, dev@openvswitch.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] openvswitch: Fix L4 checksum handling when dealing with IP fragments
Date: Mon, 10 Aug 2015 10:43:16 -0700 [thread overview]
Message-ID: <20150810174316.GA19574@google.com> (raw)
In-Reply-To: <20150803.140328.574050334230752525.davem@davemloft.net>
On Mon, Aug 03, 2015 at 02:03:28PM -0700, David Miller wrote:
> From: Glenn Griffin <ggriffin.kernel@gmail.com>
> Date: Mon, 3 Aug 2015 09:56:54 -0700
>
> > openvswitch modifies the L4 checksum of a packet when modifying
> > the ip address. When an IP packet is fragmented only the first
> > fragment contains an L4 header and checksum. Prior to this change
> > openvswitch would modify all fragments, modifying application data
> > in non-first fragments, causing checksum failures in the
> > reassembled packet.
> >
> > Signed-off-by: Glenn Griffin <ggriffin.kernel@gmail.com>
> > ---
> > Changes in v2:
> > - Compare frag_off in network byte order rather than host byte order
>
> Applied and queued up for -stable.
I noticed this change didn't seem to make it into 4.2-rc6. I'm not too
familiar with the release schedule so wasn't sure if that was expected
or an oversight. Will this remain queued up until the 4.3 merge window
opens?
next prev parent reply other threads:[~2015-08-10 17:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 16:56 [PATCH v2] openvswitch: Fix L4 checksum handling when dealing with IP fragments Glenn Griffin
[not found] ` <20150803165654.GA16892-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>
2015-08-03 17:10 ` Pravin Shelar
2015-08-03 21:03 ` David Miller
2015-08-10 17:43 ` Glenn Griffin [this message]
2015-08-10 18:23 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150810174316.GA19574@google.com \
--to=ggriffin.kernel@gmail.com \
--cc=davem@davemloft.net \
--cc=dev@openvswitch.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).