* [PATCH] bonding: Gratuitous ARP gets dropped when first slave added
@ 2015-08-11 14:57 Venkat Venkatsubra
2015-08-12 21:38 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Venkat Venkatsubra @ 2015-08-11 14:57 UTC (permalink / raw)
To: netdev; +Cc: j.vosburgh, vfalico, gospo, davem
When the first slave is added (such as during bootup) the first
gratuitous ARP gets dropped. We don't see this drop during a failover.
The packet gets dropped in qdisc (noop_enqueue).
The fix is to delay the sending of gratuitous ARPs till the bond dev's
carrier is present.
It can also be worked around by setting num_grat_arp to more than 1.
Signed-off-by: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
---
drivers/net/bonding/bond_main.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index 0c627b4..2d7d72c 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -786,6 +786,7 @@ static bool bond_should_notify_peers(struct bonding *bond)
slave ? slave->dev->name : "NULL");
if (!slave || !bond->send_peer_notif ||
+ !netif_carrier_ok(bond->dev) ||
test_bit(__LINK_STATE_LINKWATCH_PENDING, &slave->dev->state))
return false;
--
1.8.2.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] bonding: Gratuitous ARP gets dropped when first slave added
2015-08-11 14:57 [PATCH] bonding: Gratuitous ARP gets dropped when first slave added Venkat Venkatsubra
@ 2015-08-12 21:38 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-08-12 21:38 UTC (permalink / raw)
To: venkat.x.venkatsubra; +Cc: netdev, j.vosburgh, vfalico, gospo
From: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
Date: Tue, 11 Aug 2015 07:57:23 -0700
> When the first slave is added (such as during bootup) the first
> gratuitous ARP gets dropped. We don't see this drop during a failover.
> The packet gets dropped in qdisc (noop_enqueue).
>
> The fix is to delay the sending of gratuitous ARPs till the bond dev's
> carrier is present.
>
> It can also be worked around by setting num_grat_arp to more than 1.
>
> Signed-off-by: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-12 21:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-11 14:57 [PATCH] bonding: Gratuitous ARP gets dropped when first slave added Venkat Venkatsubra
2015-08-12 21:38 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).