* [patch] cosa: missing error code on failure in probe()
@ 2015-08-12 21:08 Dan Carpenter
2015-08-12 23:53 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2015-08-12 21:08 UTC (permalink / raw)
To: Jan "Yenya" Kasprzak; +Cc: netdev, kernel-janitors
If register_hdlc_device() fails, the current code returns 0 but we
should return an error code instead.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/wan/cosa.c b/drivers/net/wan/cosa.c
index 7193b73..848ea6a 100644
--- a/drivers/net/wan/cosa.c
+++ b/drivers/net/wan/cosa.c
@@ -589,7 +589,8 @@ static int cosa_probe(int base, int irq, int dma)
chan->netdev->base_addr = chan->cosa->datareg;
chan->netdev->irq = chan->cosa->irq;
chan->netdev->dma = chan->cosa->dma;
- if (register_hdlc_device(chan->netdev)) {
+ err = register_hdlc_device(chan->netdev);
+ if (err) {
netdev_warn(chan->netdev,
"register_hdlc_device() failed\n");
free_netdev(chan->netdev);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch] cosa: missing error code on failure in probe()
2015-08-12 21:08 [patch] cosa: missing error code on failure in probe() Dan Carpenter
@ 2015-08-12 23:53 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2015-08-12 23:53 UTC (permalink / raw)
To: dan.carpenter; +Cc: kas, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 13 Aug 2015 00:08:01 +0300
> If register_hdlc_device() fails, the current code returns 0 but we
> should return an error code instead.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks Dan.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-08-12 23:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-08-12 21:08 [patch] cosa: missing error code on failure in probe() Dan Carpenter
2015-08-12 23:53 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).