From: Stephen Hemminger <stephen@networkplumber.org>
To: Phil Sutter <phil@nwl.cc>
Cc: netdev@vger.kernel.org, brouer@redhat.com,
alexei.starovoitov@gmail.com, davem@davemloft.net, fw@strlen.de,
cwang@twopensource.com, eric.dumazet@gmail.com
Subject: Re: [PATCH 0/2] net: introduce IFF_NO_QUEUE as successor of zero tx_queue_len
Date: Thu, 13 Aug 2015 10:49:50 -0700 [thread overview]
Message-ID: <20150813104950.1b8346f2@urahara> (raw)
In-Reply-To: <1439485268-20953-1-git-send-email-phil@nwl.cc>
On Thu, 13 Aug 2015 19:01:05 +0200
Phil Sutter <phil@nwl.cc> wrote:
> Up to now, drivers being aware of the above applying to them set
> dev->tx_queue_len to zero to indicate no qdisc should be attached to the
> interface they drive and the kernel reacts upon this by assigning the noop
> qdisc instead of the default pfifo_fast. This implicit agreement though leads
> to an inconvenient situation once a user tries to attach a real qdisc to these
> devices, as the formerly special tx_queue_len value becomes a regular one,
So this is a workaround for user ignorance by introducing kernel API complexity.
Before user sets qdisc, why don't they set tx queue length?
next prev parent reply other threads:[~2015-08-13 17:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 17:01 [PATCH 0/2] net: introduce IFF_NO_QUEUE as successor of zero tx_queue_len Phil Sutter
2015-08-13 17:01 ` [PATCH 1/2] net: declare new net_device priv_flag IFF_NO_QUEUE Phil Sutter
2015-08-13 17:01 ` [PATCH 2/2] net: sch_generic: react upon IFF_NO_QUEUE flag Phil Sutter
2015-08-17 6:53 ` Jesper Dangaard Brouer
2015-08-17 6:52 ` [PATCH 1/2] net: declare new net_device priv_flag IFF_NO_QUEUE Jesper Dangaard Brouer
2015-08-13 17:49 ` Stephen Hemminger [this message]
2015-08-13 18:40 ` [PATCH 0/2] net: introduce IFF_NO_QUEUE as successor of zero tx_queue_len Jesper Dangaard Brouer
2015-08-13 19:11 ` Stephen Hemminger
2015-08-14 8:41 ` Phil Sutter
2015-08-17 6:51 ` Jesper Dangaard Brouer
2015-08-17 13:44 ` Eric Dumazet
2015-08-17 15:16 ` Jesper Dangaard Brouer
2015-08-17 18:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150813104950.1b8346f2@urahara \
--to=stephen@networkplumber.org \
--cc=alexei.starovoitov@gmail.com \
--cc=brouer@redhat.com \
--cc=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).