netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Peter Chen <peter.chen@freescale.com>
To: Lucas Stach <l.stach@pengutronix.de>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Duan Andy <fugang.duan@freescale.com>,
	"shawn.guo@linaro.org" <shawn.guo@linaro.org>,
	Fabio Estevam <Fabio.Estevam@freescale.com>,
	"tyler.baker@linaro.org" <tyler.baker@linaro.org>,
	Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH 1/1] Revert "net: fec: Ensure clocks are enabled while using mdio bus"
Date: Fri, 14 Aug 2015 16:14:45 +0800	[thread overview]
Message-ID: <20150814081444.GD11072@shlinux2> (raw)
In-Reply-To: <1439540853.13210.26.camel@pengutronix.de>

On Fri, Aug 14, 2015 at 10:27:33AM +0200, Lucas Stach wrote:
> Am Freitag, den 14.08.2015, 08:25 +0000 schrieb Peter Chen:
> >  
> > > 
> > > Am Freitag, den 14.08.2015, 13:47 +0800 schrieb Peter Chen:
> > > > It causes the i.mx6sx sdb board hang when using nfsroot during boots
> > > > up at v4.2-rc6.
> > > >
> > > > This reverts commit 8fff755e9f8d0f70a595e79f248695ce6aef5cc3.
> > > >
> > > > Cc: netdev@vger.kernel.org
> > > > Cc: Fugang Duan <B38611@freescale.com>
> > > > Cc: shawn.guo@linaro.org
> > > > Cc: fabio.estevam@freescale.com
> > > > Cc: tyler.baker@linaro.org
> > > > Cc: Lucas Stach <l.stach@pengutronix.de>
> > > > Cc: Andrew Lunn <andrew@lunn.ch>
> > > > Signed-off-by: Peter Chen <peter.chen@freescale.com>
> > > > ---
> > > >
> > > > According to Fugang Duan, the i.mx series has different clock control
> > > > sequence among SoCs, this patch may only consider certain SoCs.
> > > >
> > > Sorry, but NACK.
> > > 
> > > Please test current mainline (what will become v4.2-rc7). There is already a
> > > patch in that fixes i.MX27 and probably fixes the same problem on i.MX6SX.
> > > 
> > 
> > Would you help point to me which commit and at which tree?
> > 
> Mainline, so Linus Torvalds tree.
> 
> http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=14d2b7c1a96ef37eb571599c73d4a1a606b964d6

It fixes my imx6sx-sdb board. It is interesting that there was
no problem for some platforms, but with problem for others.
Your fix is a common runtime PM fix.

Again, why we need this as a bug-fix, not but as new feature for next
rc1?

-- 

Best Regards,
Peter Chen

  reply	other threads:[~2015-08-14  9:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-14  5:47 [PATCH 1/1] Revert "net: fec: Ensure clocks are enabled while using mdio bus" Peter Chen
2015-08-14  7:03 ` Duan Andy
2015-08-14  8:22 ` Lucas Stach
2015-08-14  8:25   ` Peter Chen
2015-08-14  8:27     ` Lucas Stach
2015-08-14  8:14       ` Peter Chen [this message]
2015-08-14  9:36         ` Lucas Stach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150814081444.GD11072@shlinux2 \
    --to=peter.chen@freescale.com \
    --cc=Fabio.Estevam@freescale.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=fugang.duan@freescale.com \
    --cc=l.stach@pengutronix.de \
    --cc=netdev@vger.kernel.org \
    --cc=shawn.guo@linaro.org \
    --cc=tyler.baker@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).