netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Graf <tgraf@suug.ch>
To: Jiri Benc <jbenc@redhat.com>
Cc: netdev@vger.kernel.org, Roopa Prabhu <roopa@cumulusnetworks.com>
Subject: Re: [PATCH net-next] lwtunnel: rename ip lwtunnel attributes
Date: Fri, 14 Aug 2015 18:51:07 +0200	[thread overview]
Message-ID: <20150814165107.GA6431@pox.localdomain> (raw)
In-Reply-To: <f6abe6522e88ea21d2ccf6e50f9e563fdf8f3a37.1439563196.git.jbenc@redhat.com>

On 08/14/15 at 04:40pm, Jiri Benc wrote:
> We already have IFLA_IPTUN_ netlink attributes. The IP_TUN_ attributes look
> very similar, yet they serve very different purpose. This is confusing for
> anyone trying to implement a user space tool supporting lwt.
> 
> As the IP_TUN_ attributes are used only for the lightweight tunnels, prefix
> them with LWTUNNEL_IP_ instead to make their purpose clear. Also, it's more
> logical to have them in lwtunnel.h together with the encap enum.
> 
> Fixes: 3093fbe7ff4b ("route: Per route IP tunnel metadata via lightweight tunnel")
> Signed-off-by: Jiri Benc <jbenc@redhat.com>

Acked-by: Thomas Graf <tgraf@suug.ch>

> ---
> These are still in net-next only, thus it's safe to change them.
> 
> It's still a bit weird these attributes are in RTA_ENCAP, perhaps we should
> also rename RTA_ENCAP to RTA_LWT_ENCAP or similar?

I think RTA_ENCAP is fine but I don't mind changing it either.

  reply	other threads:[~2015-08-14 16:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-14 14:40 [PATCH net-next] lwtunnel: rename ip lwtunnel attributes Jiri Benc
2015-08-14 16:51 ` Thomas Graf [this message]
2015-08-17 21:07 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150814165107.GA6431@pox.localdomain \
    --to=tgraf@suug.ch \
    --cc=jbenc@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=roopa@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).