From: Florian Westphal <fw@strlen.de>
To: Phil Sutter <phil@nwl.cc>
Cc: Thomas Graf <tgraf@suug.ch>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
davem@davemloft.net
Subject: Re: [PATCH] rhashtable-test: extend to test concurrency
Date: Sun, 16 Aug 2015 20:12:35 +0200 [thread overview]
Message-ID: <20150816181234.GC31357@breakpoint.cc> (raw)
In-Reply-To: <1439591835-30357-1-git-send-email-phil@nwl.cc>
Phil Sutter <phil@nwl.cc> wrote:
> After having tested insertion, lookup, table walk and removal, spawn a
> number of threads running operations on the same rhashtable. Each of
> them will:
[..]
> + if (down_interruptible(&startup_sem))
> + pr_err(" thread[%d]: down_interruptible failed\n", tdata->id);
Why _interruptible?
Seems this should use down() instead.
next prev parent reply other threads:[~2015-08-16 18:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-14 22:37 [PATCH] rhashtable-test: extend to test concurrency Phil Sutter
2015-08-16 15:02 ` Thomas Graf
2015-08-16 18:12 ` Florian Westphal [this message]
2015-08-16 21:46 ` Phil Sutter
2015-08-17 21:32 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150816181234.GC31357@breakpoint.cc \
--to=fw@strlen.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox