From: David Miller <davem@davemloft.net>
To: phil@nwl.cc
Cc: netdev@vger.kernel.org, tgraf@suug.ch
Subject: Re: [PATCH] net: rtnetlink: be more strict when setting MAC address
Date: Mon, 17 Aug 2015 14:09:33 -0700 (PDT) [thread overview]
Message-ID: <20150817.140933.1342685440755543932.davem@davemloft.net> (raw)
In-Reply-To: <1439845607-2824-1-git-send-email-phil@nwl.cc>
From: Phil Sutter <phil@nwl.cc>
Date: Mon, 17 Aug 2015 23:06:47 +0200
> Upon evaluation of IFLA_ADDRESS and IFLA_BROADCAST messages, make sure
> the passed argument length matches dev->addr_len exactly.
>
> This fixes dubious behaviour of 'ip link set eth0 addr <MAC>' where
> '<MAC>' is too long, e.g. '00:11:22:33:44:55:66:77'. Called like this,
> 'ip' would return successfully and the kernel sets eth0's MAC address to
> the leading six octets of the passed argument.
>
> Signed-off-by: Phil Sutter <phil@nwl.cc>
I don't think this behavior is very "dubious" and making the check more
strict risks breaking things that have worked for a very long time.
I'm not applying this, sorry.
next prev parent reply other threads:[~2015-08-17 21:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-17 21:06 [PATCH] net: rtnetlink: be more strict when setting MAC address Phil Sutter
2015-08-17 21:09 ` David Miller [this message]
2015-08-17 23:23 ` Phil Sutter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150817.140933.1342685440755543932.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).