From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Phil Sutter <phil@nwl.cc>
Cc: brouer@redhat.com, Stephen Hemminger <stephen@networkplumber.org>,
netdev@vger.kernel.org, alexei.starovoitov@gmail.com,
davem@davemloft.net, fw@strlen.de, cwang@twopensource.com,
eric.dumazet@gmail.com
Subject: Re: [PATCH 0/2] net: introduce IFF_NO_QUEUE as successor of zero tx_queue_len
Date: Mon, 17 Aug 2015 08:51:21 +0200 [thread overview]
Message-ID: <20150817085121.419a1d28@redhat.com> (raw)
In-Reply-To: <20150814084153.GI32353@orbit.nwl.cc>
On Fri, 14 Aug 2015 10:41:53 +0200 Phil Sutter <phil@nwl.cc> wrote:
> On Thu, Aug 13, 2015 at 12:11:57PM -0700, Stephen Hemminger wrote:
[...]
> >
> > But adding a flag risks breaking external scripts.
>
> Could you please elaborate on this? As far as I can tell, introducing a
> separate flag is the only solution *not* breaking existing scripts. So
> if you see the rub, I would like to know where exactly it is.
I agree with Phil. AFAIC see this approach does not break existing
scripts.
Acked-by: Jesper Dangaard Brouer <brouer@redhat.com>
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Sr. Network Kernel Developer at Red Hat
Author of http://www.iptv-analyzer.org
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2015-08-17 6:51 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 17:01 [PATCH 0/2] net: introduce IFF_NO_QUEUE as successor of zero tx_queue_len Phil Sutter
2015-08-13 17:01 ` [PATCH 1/2] net: declare new net_device priv_flag IFF_NO_QUEUE Phil Sutter
2015-08-13 17:01 ` [PATCH 2/2] net: sch_generic: react upon IFF_NO_QUEUE flag Phil Sutter
2015-08-17 6:53 ` Jesper Dangaard Brouer
2015-08-17 6:52 ` [PATCH 1/2] net: declare new net_device priv_flag IFF_NO_QUEUE Jesper Dangaard Brouer
2015-08-13 17:49 ` [PATCH 0/2] net: introduce IFF_NO_QUEUE as successor of zero tx_queue_len Stephen Hemminger
2015-08-13 18:40 ` Jesper Dangaard Brouer
2015-08-13 19:11 ` Stephen Hemminger
2015-08-14 8:41 ` Phil Sutter
2015-08-17 6:51 ` Jesper Dangaard Brouer [this message]
2015-08-17 13:44 ` Eric Dumazet
2015-08-17 15:16 ` Jesper Dangaard Brouer
2015-08-17 18:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150817085121.419a1d28@redhat.com \
--to=brouer@redhat.com \
--cc=alexei.starovoitov@gmail.com \
--cc=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).