From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Miller Subject: Re: [patch] cxgb4: memory corruption in debugfs Date: Tue, 18 Aug 2015 19:07:21 -0700 (PDT) Message-ID: <20150818.190721.630738689965121571.davem@davemloft.net> References: <20150818093144.GG3965@mwanda> Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: hariprasad@chelsio.com, netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: dan.carpenter@oracle.com Return-path: In-Reply-To: <20150818093144.GG3965@mwanda> Sender: kernel-janitors-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Dan Carpenter Date: Tue, 18 Aug 2015 12:31:44 +0300 > You can't use kstrtoul() with an int or it causes memory corruption. > Also j should be unsigned or we have underflow bugs. > > I considered changing "j" to unsigned long but everything fits in a u32. > > Fixes: 8e3d04fd7d70 ('cxgb4: Add MPS tracing support') > Signed-off-by: Dan Carpenter Applied, thanks Dan.