From: David Miller <davem@davemloft.net>
To: razor@blackwall.org
Cc: netdev@vger.kernel.org, dsa@cumulusnetworks.com,
shm@cumulusnetworks.com, nikolay@cumulusnetworks.com
Subject: Re: [PATCH net-next v3] vrf: vrf_master_ifindex_rcu is not always called with rcu read lock
Date: Tue, 18 Aug 2015 20:24:21 -0700 (PDT) [thread overview]
Message-ID: <20150818.202421.1780385295480410922.davem@davemloft.net> (raw)
In-Reply-To: <1439923216-25295-1-git-send-email-razor@blackwall.org>
From: Nikolay Aleksandrov <razor@blackwall.org>
Date: Tue, 18 Aug 2015 21:40:16 +0300
> From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
>
> While running net-next I hit this:
...
> It would seem vrf_master_ifindex_rcu() can be called without RCU held in
> other contexts as well so introduce a new helper which acquires rcu and
> returns the ifindex.
> Also add curly braces around both the "if" and "else" parts as per the
> style guide.
>
> Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
> ---
> v3: keep the rcu comment above vrf_master_ifindex_rcu()
> v2: use a new helper that acquires and releases rcu instead
Applied, thanks.
next prev parent reply other threads:[~2015-08-19 3:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-18 16:17 [PATCH net-next] vrf: vrf_master_ifindex_rcu is not always called with rcu read lock Nikolay Aleksandrov
2015-08-18 18:15 ` [PATCH net-next v2] " Nikolay Aleksandrov
2015-08-18 20:10 ` David Ahern
2015-08-18 20:24 ` Nikolay Aleksandrov
2015-08-18 18:40 ` [PATCH net-next v3] " Nikolay Aleksandrov
2015-08-19 3:24 ` David Miller [this message]
2015-08-18 19:45 ` [PATCH net-next] " David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150818.202421.1780385295480410922.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsa@cumulusnetworks.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=razor@blackwall.org \
--cc=shm@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).